Various optimizations to reduce the number of temporary allocations.

chrome/browser/themes/theme_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_service.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted_memory.h"
@@ skipping 218 matching lines @@
   if (HasCustomImage(IDR_THEME_FRAME))
     return false;
 #if defined(OS_WIN)
   return ui::win::IsAeroGlassEnabled();
 #else
   return false;
 #endif
 }
 
 bool ThemeService::HasCustomImage(int id) const {
-  if (!Properties::IsThemeableImage(id))
+  if (!BrowserThemePack::IsPersistentImageID(id))

[Peter Kasting, 2014/12/03 22:08:38]

Optional: While you're here, a shorter way would be:

  return BrowserThemePack::IsPersistentImageID(id) &&
      theme_supplier_ && theme_supplier_->HasCustomImage(id);

(This also removes the unnecessary .get().)

     return false;
 
   if (theme_supplier_.get())
     return theme_supplier_->HasCustomImage(id);
 
   return false;
 }
 
 base::RefCountedMemory* ThemeService::GetRawData(
     int id,
@@ skipping 384 matching lines @@
 void ThemeService::OnInfobarDestroyed() {
   number_of_infobars_--;
 
   if (number_of_infobars_ == 0)
     RemoveUnusedThemes(false);
 }
 
 ThemeSyncableService* ThemeService::GetThemeSyncableService() const {
   return theme_syncable_service_.get();
 }