Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 746713002: Move InspectorBackendMojo out of the blink namespace (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
yurys, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move InspectorBackendMojo out of the blink namespace This starts to break the dependency between blink and the new v8_inspector. At least now the front-end object InspectorBackendMojo is treated as a peer to WebView instead of WebView providing one. Unfortunately I also had to teach Page about InspectorHost in order to make it possible to lookup the InspectorHost from the v8::Context. I'm sure there is a nicer way to associate the InspectorHost with the context but for now I've chosen this path, we can untangle the connection in a later patch. I also ended up removing Page::allPages and all callers, since they ended up as dead code. R=abarth@chromium.org, yurys@chromium.org BUG=435243 Committed: https://chromium.googlesource.com/external/mojo/+/8729b0e4058c8efbdfbc8cad77249aac13c0365f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -221 lines) Patch
M sky/engine/bindings/core/v8/PageScriptDebugServer.h View 3 chunks +15 lines, -11 lines 0 comments Download
M sky/engine/bindings/core/v8/PageScriptDebugServer.cpp View 6 chunks +36 lines, -46 lines 1 comment Download
M sky/engine/core/inspector/PageDebuggerAgent.h View 3 chunks +9 lines, -4 lines 0 comments Download
M sky/engine/core/inspector/PageDebuggerAgent.cpp View 3 chunks +14 lines, -13 lines 0 comments Download
M sky/engine/core/page/Page.h View 6 chunks +12 lines, -12 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 5 chunks +1 line, -53 lines 0 comments Download
M sky/engine/public/web/WebView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/v8_inspector/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A sky/engine/v8_inspector/README.md View 1 chunk +17 lines, -0 lines 0 comments Download
M sky/engine/v8_inspector/inspector_backend_mojo.h View 1 chunk +15 lines, -36 lines 0 comments Download
M sky/engine/v8_inspector/inspector_backend_mojo.cc View 5 chunks +67 lines, -26 lines 0 comments Download
A sky/engine/v8_inspector/inspector_host.h View 1 chunk +29 lines, -0 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 6 chunks +3 lines, -11 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/viewer/document_view.h View 3 chunks +9 lines, -0 lines 0 comments Download
M sky/viewer/document_view.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M sky/viewer/services/inspector_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
6 years, 1 month ago (2014-11-20 22:16:15 UTC) #1
eseidel
https://codereview.chromium.org/746713002/diff/1/sky/engine/bindings/core/v8/PageScriptDebugServer.cpp File sky/engine/bindings/core/v8/PageScriptDebugServer.cpp (left): https://codereview.chromium.org/746713002/diff/1/sky/engine/bindings/core/v8/PageScriptDebugServer.cpp#oldcode125 sky/engine/bindings/core/v8/PageScriptDebugServer.cpp:125: v8::Local<v8::Value> console = gin::Console::GetModule(m_isolate); I also removed this as ...
6 years, 1 month ago (2014-11-20 22:19:53 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-20 22:20:48 UTC) #3
eseidel
6 years, 1 month ago (2014-11-20 22:21:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8729b0e4058c8efbdfbc8cad77249aac13c0365f.

Powered by Google App Engine
This is Rietveld 408576698