Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(397)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/engine/v8_inspector/README.md
Issue
746713002
:
Move InspectorBackendMojo out of the blink namespace (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set:
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/engine/bindings/core/v8/PageScriptDebugServer.h
sky/engine/bindings/core/v8/PageScriptDebugServer.cpp
sky/engine/core/inspector/PageDebuggerAgent.h
sky/engine/core/inspector/PageDebuggerAgent.cpp
sky/engine/core/page/Page.h
sky/engine/core/page/Page.cpp
sky/engine/public/web/WebView.h
sky/engine/v8_inspector/BUILD.gn
sky/engine/v8_inspector/README.md
sky/engine/v8_inspector/inspector_backend_mojo.h
sky/engine/v8_inspector/inspector_backend_mojo.cc
sky/engine/v8_inspector/inspector_host.h
sky/engine/web/WebViewImpl.h
sky/engine/web/WebViewImpl.cpp
sky/viewer/BUILD.gn
sky/viewer/document_view.h
sky/viewer/document_view.cc
sky/viewer/services/inspector_impl.cc
View unified diff
|
Download patch
« sky/engine/bindings/core/v8/PageScriptDebugServer.cpp
('K') |
« sky/engine/v8_inspector/BUILD.gn
('k') |
sky/engine/v8_inspector/inspector_backend_mojo.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
v8_inspector
2
============
3
4
v8_inspector is an attempt to build a standalone library for running
5
a Chrome-DevTools compatible WebSocket server which speaks the "Debugger"
6
portion of the DevTools json protocol.
7
8
Currently v8_inspector is deeply tied into the rest of sky/engine/core,
9
however the goal is to remove that dependency by moving the files out of
10
sky/engine/core.
11
12
13
More Information
14
================
15
16
https://docs.google.com/document/d/1fEkZFMH_U5DhIYM95Mhp5ovtBUeHaToSvgQapDzgNDc/ edit
17
http://crbug.com/435243
OLD
NEW
« sky/engine/bindings/core/v8/PageScriptDebugServer.cpp
('K') |
« sky/engine/v8_inspector/BUILD.gn
('k') |
sky/engine/v8_inspector/inspector_backend_mojo.h »
('j') |
no next file with comments »
Issue 746713002: Move InspectorBackendMojo out of the blink namespace (Closed)
Created 6 years, 1 month ago by eseidel
Modified 6 years, 1 month ago
Reviewers: abarth-chromium, yurys
Base URL: git@github.com:domokit/mojo.git@master
Comments: 1
This is Rietveld
408576698