Made Destroy() followup more aggressive to test for races.

Made Destroy() followup more aggressive to test for races.

In particular we now free output textures and input bitstream buffers as soon as
Destroy() returns, in an attempt to trip up race conditions between
OVDA::Destroy() returning and the openmax libs/drivers/hardware attempting to
use no-longer-valid memory.

Also made DestroyVideoDecoder a SYNChronous IPC message again to match VideoDecodeAccelerator::Destroy()'s contract.

Also explicitly set to NULL pointers that are made invalid or no-longer useful by Destroy(), in the pepper glue code, to make crashes more obvious if they happen.

[No crashes have been observed in gles2 or ovdatest; this CL is just to increase (currently manual) test coverage]

BUG=none
TEST=gles2 mid-decode reload works, ovdatest passes

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94148

[Ami GONE FROM CHROMIUM, 2011-07-25 23:04:04]

brettw: OWNERS please
vrk: please review

[brettw, 2011-07-26 16:17:01]

LGTM rubberstamp

[vrk (LEFT CHROMIUM), 2011-07-26 17:33:19]

LGTM

http://codereview.chromium.org/7467037/diff/5001/content/common/gpu/media/omx...
File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc (right):

http://codereview.chromium.org/7467037/diff/5001/content/common/gpu/media/omx...
content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:567:
DCHECK(inserted);
nit: change DCHECK to CHECK here and elsewhere.

[Ami GONE FROM CHROMIUM, 2011-07-26 18:05:09]

http://codereview.chromium.org/7467037/diff/5001/content/common/gpu/media/omx...
File content/common/gpu/media/omx_video_decode_accelerator_unittest.cc (right):

http://codereview.chromium.org/7467037/diff/5001/content/common/gpu/media/omx...
content/common/gpu/media/omx_video_decode_accelerator_unittest.cc:567:
DCHECK(inserted);
On 2011/07/26 17:33:20, Victoria Kirst wrote:
> nit: change DCHECK to CHECK here and elsewhere.

Done.

[commit-bot: I haz the power, 2011-07-26 19:31:04]

Try job failure for 7467037-5001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-07-28 16:30:51]

Can't apply patch for file webkit/plugins/ppapi/ppb_video_decoder_impl.cc.
While running patch -p1 --forward --force;
patching file webkit/plugins/ppapi/ppb_video_decoder_impl.cc
Hunk #1 FAILED at 176.
1 out of 1 hunk FAILED -- saving rejects to file
webkit/plugins/ppapi/ppb_video_decoder_impl.cc.rej