content/renderer/web_ui_extension.cc - Issue 746663002: Stub for WebRTCDeviceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/web_ui_extension.cc

Issue 746663002: Stub for WebRTCDeviceProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webclient

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/web_ui_extension.cc

diff --git a/content/renderer/web_ui_extension.cc b/content/renderer/web_ui_extension.cc

index 127912630d8ffbafd00dba8c85b79ccef258d6b3..0747dc6fb9919357a28aef82ea2c5628dca984df 100644

--- a/content/renderer/web_ui_extension.cc

+++ b/content/renderer/web_ui_extension.cc

@@ -43,6 +43,7 @@ bool ShouldRespondToRequest(

bool webui_enabled =

(render_view->GetEnabledBindings() & BINDINGS_POLICY_WEB_UI) &&

(frame_url.SchemeIs(kChromeUIScheme) ||

+ frame_url.SchemeIs(kChromeDevToolsScheme) ||

Tom Sepez 2014/11/21 18:51:38 No. This violates the principle of least privileg

SeRya 2014/11/24 11:10:06 As we discussed, this change does the following th

frame_url.SchemeIs(url::kDataScheme));

if (!webui_enabled)