Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2012 The Chromium Authors. All rights reserved. | 1 // Copyright 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "content/renderer/web_ui_extension.h" | 5 #include "content/renderer/web_ui_extension.h" |
| 6 | 6 |
| 7 #include "base/memory/scoped_ptr.h" | 7 #include "base/memory/scoped_ptr.h" |
| 8 #include "base/values.h" | 8 #include "base/values.h" |
| 9 #include "content/common/view_messages.h" | 9 #include "content/common/view_messages.h" |
| 10 #include "content/public/common/bindings_policy.h" | 10 #include "content/public/common/bindings_policy.h" |
| (...skipping 25 matching lines...) Expand all Loading... | |
| 36 | 36 |
| 37 RenderView* render_view = RenderView::FromWebView(frame->view()); | 37 RenderView* render_view = RenderView::FromWebView(frame->view()); |
| 38 if (!render_view) | 38 if (!render_view) |
| 39 return false; | 39 return false; |
| 40 | 40 |
| 41 GURL frame_url = frame->document().url(); | 41 GURL frame_url = frame->document().url(); |
| 42 | 42 |
| 43 bool webui_enabled = | 43 bool webui_enabled = |
| 44 (render_view->GetEnabledBindings() & BINDINGS_POLICY_WEB_UI) && | 44 (render_view->GetEnabledBindings() & BINDINGS_POLICY_WEB_UI) && |
| 45 (frame_url.SchemeIs(kChromeUIScheme) || | 45 (frame_url.SchemeIs(kChromeUIScheme) || |
| 46 frame_url.SchemeIs(kChromeDevToolsScheme) || | |
|
Tom Sepez
2014/11/21 18:51:38
No. This violates the principle of least privileg
SeRya
2014/11/24 11:10:06
As we discussed, this change does the following th
| |
| 46 frame_url.SchemeIs(url::kDataScheme)); | 47 frame_url.SchemeIs(url::kDataScheme)); |
| 47 | 48 |
| 48 if (!webui_enabled) | 49 if (!webui_enabled) |
| 49 return false; | 50 return false; |
| 50 | 51 |
| 51 *frame_ptr = frame; | 52 *frame_ptr = frame; |
| 52 *render_view_ptr = render_view; | 53 *render_view_ptr = render_view; |
| 53 return true; | 54 return true; |
| 54 } | 55 } |
| 55 | 56 |
| (...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 127 std::string WebUIExtension::GetVariableValue(const std::string& name) { | 128 std::string WebUIExtension::GetVariableValue(const std::string& name) { |
| 128 blink::WebFrame* frame; | 129 blink::WebFrame* frame; |
| 129 RenderView* render_view; | 130 RenderView* render_view; |
| 130 if (!ShouldRespondToRequest(&frame, &render_view)) | 131 if (!ShouldRespondToRequest(&frame, &render_view)) |
| 131 return std::string(); | 132 return std::string(); |
| 132 | 133 |
| 133 return WebUIExtensionData::Get(render_view)->GetValue(name); | 134 return WebUIExtensionData::Get(render_view)->GetValue(name); |
| 134 } | 135 } |
| 135 | 136 |
| 136 } // namespace content | 137 } // namespace content |
| OLD | NEW |