chrome/common/visitedlink_common.cc - Issue 7466003: MD5Update function uses StringPiece instead of raw buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/visitedlink_common.cc

Issue 7466003: MD5Update function uses StringPiece instead of raw buffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added valid license Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/visitedlink_common.cc

diff --git a/chrome/common/visitedlink_common.cc b/chrome/common/visitedlink_common.cc

index 7fb254e745382183394f69165ac1b3e50a09b6eb..7c21054a6f1fa0de65d843e82af60b8d5fe7620c 100644

--- a/chrome/common/visitedlink_common.cc

+++ b/chrome/common/visitedlink_common.cc

@@ -81,8 +81,9 @@ VisitedLinkCommon::Fingerprint VisitedLinkCommon::ComputeURLFingerprint(

base::MD5Context ctx;

base::MD5Init(&ctx);

- base::MD5Update(&ctx, salt, LINK_SALT_LENGTH * sizeof(uint8));

- base::MD5Update(&ctx, canonical_url, url_len * sizeof(char));

+ base::MD5Update(&ctx, base::StringPiece(reinterpret_cast<const char*>(salt),

+ LINK_SALT_LENGTH));

+ base::MD5Update(&ctx, base::StringPiece(canonical_url, url_len));

base::MD5Digest digest;

base::MD5Final(&digest, &ctx);