MD5Update function uses StringPiece instead of raw buffer.

base/md5_unittest.cc

Index: base/md5_unittest.cc
diff --git a/base/md5_unittest.cc b/base/md5_unittest.cc
index c81ff123f023700df3ca23163be25f036dab090c..def47fb723d81ffe9c57b8c675184bb9026de901 100644
--- a/base/md5_unittest.cc
+++ b/base/md5_unittest.cc
@@ -120,7 +120,8 @@ TEST(MD5, ContextWithLongData) {
     if (len > length - total)
       len = length - total;
 
-    MD5Update(&ctx, data.get() + total, len);
+    MD5Update(&ctx,
+              StringPiece(reinterpret_cast<char*>(data.get() + total), len));
     total += len;
   }
 
@@ -188,4 +189,22 @@ TEST(MD5, MD5StringTestSuite7) {
   EXPECT_EQ(expected, actual);
 }
 
+TEST(MD5, ContextWithStringData) {
+  MD5Context ctx;
+  MD5Init(&ctx);
+
+  std::string data = "abc";
+  std::string expected = "900150983cd24fb0d6963f7d28e17f72";

[tfarina, 2011/07/21 22:18:54]

could you move expected near of |actual| below?

[dominich, 2011/07/25 20:58:27]

Done.

+
+  MD5Update(&ctx, data);

[tfarina, 2011/07/21 22:18:54]

can you pass "abc" directly?

[dominich, 2011/07/25 20:58:27]

Done.

+
+  MD5Digest digest;
+  MD5Final(&digest, &ctx);
+
+  std::string actual = MD5DigestToBase16(digest);
+
+  EXPECT_EQ(expected, actual);
+}
+
+

[tfarina, 2011/07/21 22:18:54]

remove this extra blank line.

[dominich, 2011/07/25 20:58:27]

Done.

 }  // namespace base