Issue 746433002: Revive tests for Attr.ownerElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 746433002: Revive tests for Attr.ownerElement (Closed)

Created:
6 years, 1 month ago by philipj_slow

Modified:
6 years, 1 month ago

Reviewers:
pdr.

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revive tests for Attr.ownerElement This brings back some tests removed in https://codereview.chromium.org/124643003 The removal didn't work out. BUG=305105, 353104 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185698

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -0 lines)			Patch
M	LayoutTests/dom/svg/level3/xpath/Attribute_Nodes.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Attr/access-after-element-destruction-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Attr/script-tests/access-after-element-destruction.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

philipj_slow

PTAL. These tests aren't great, but they're better than nothing.

6 years, 1 month ago (2014-11-20 15:32:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746433002/1

6 years, 1 month ago (2014-11-20 19:32:14 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-20 20:21:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185698