Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 124643003: Remove Attr.isId and Attr.ownerElement. (Closed)

Created:
6 years, 11 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 11 months ago
Reviewers:
eseidel
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove Attr.isId and Attr.ownerElement. These properties were removed in DOM4 <http://dom.spec.whatwg.org/#interface-attr>;. Use counters AttributeIsId and AttributeOwnerElement indicate they're rarely used on the web (<0.01%.) BUG=305105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164820

Patch Set 1 #

Patch Set 2 : Bring patch to head. #

Patch Set 3 : Bump unused use counter slot number due to conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -468 lines) Patch
M LayoutTests/dom/svg/level3/xpath/Attribute_Nodes.js View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/attrisid04.js View 1 chunk +0 lines, -127 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/attrisid04-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/attrisid05.js View 1 chunk +0 lines, -135 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/dom/xhtml/level3/core/attrisid05-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Attr/access-after-element-destruction-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Attr/script-tests/access-after-element-destruction.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/Element/attrisid-extra01.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/Element/attrisid-extra01-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/dom/Attr.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Attr.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Attr.idl View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dominicc (has gone to gerrit)
PTAL Use counters report 0.00% for these, so I'm removing them without an Intent to ...
6 years, 11 months ago (2014-01-05 01:11:27 UTC) #1
eseidel
I would still send an Intent to Deprecate and Remove, since removing things from the ...
6 years, 11 months ago (2014-01-06 15:00:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/124643003/120001
6 years, 11 months ago (2014-01-09 22:32:16 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 01:40:21 UTC) #4
Message was sent while issue was closed.
Change committed as 164820

Powered by Google App Engine
This is Rietveld 408576698