Issue 746303002: Make gn check //examples/* pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 746303002: Make gn check //examples/* pass (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -1 line)			Patch
M	PRESUBMIT.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/apptest/BUILD.gn	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	examples/aura_demo/BUILD.gn	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	examples/bitmap_uploader/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	examples/embedded_app/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/ganesh_app/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	examples/http_handler/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/nesting_app/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/pdf_viewer/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/recursive_content_handler/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	examples/sample_app/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

jamesr

6 years, 1 month ago (2014-11-22 00:23:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1466396ae7916ecdefaff7277b0d64bdd3efaf28 (presubmit successful).