PRESUBMIT.py - Issue 746303002: Make gn check //examples/* pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 746303002: Make gn check //examples/* pass (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index da80e2a506f37b27b722254147a77e65d8a5a480..8a5732805c0f54c37c65d16a815c625cd845764b 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -444,6 +444,7 @@ def _CheckGNCheck(input_api, output_api):

# TODO(eseidel): Currently only these are known to pass,

# once everything passes we can just call 'gn check' once without a filter!

KNOWN_PASSING = [

+ '//examples/*',

'//mojo/aura/*',

'//mojo/application/*',

'//mojo/application_manager/*',

« no previous file with comments | « no previous file | examples/apptest/BUILD.gn » ('j') | no next file with comments »