Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 746173002: Respect fallback colors when interpolating text-decoration-color. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dstockwell, blink-reviews-rendering, jchaffraix+rendering, darktears, Steve Block, zoltan1, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Respect fallback colors when interpolating text-decoration-color. Currently, we interpolate the incorrect colors if one of the fallback colors (other than currentColor) are used for text decoration. This happens because we bypass the fallback code when creating the AnimatableValues. This patch moves the color retrieving code for text decoration into the main RenderStyle::colorIncludingCallback function, and changes callers to use visitedDependentColor/colorIncludingFallback also for CSSPropertyTextDecorationColor. This is better, because you don't have to do anything special with the text decoration color compared to all other colors. R=alancutter@chromium.org BUG=435546 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M LayoutTests/animations/interpolation/text-decoration-color-interpolation.html View 2 chunks +15 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/text-decoration-color-interpolation-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 3 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
andersr
6 years, 1 month ago (2014-11-21 13:50:05 UTC) #1
alancutter (OOO until 2018)
lgtm thanks!
6 years, 1 month ago (2014-11-24 00:01:10 UTC) #2
Timothy Loh
On 2014/11/24 00:01:10, alancutter wrote: > lgtm thanks! OWNER rubber stamp lgtm
6 years, 1 month ago (2014-11-24 02:10:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/746173002/1
6 years ago (2014-11-24 09:43:03 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 12:23:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185870

Powered by Google App Engine
This is Rietveld 408576698