Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 746173002: Respect fallback colors when interpolating text-decoration-color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 746173002: Respect fallback colors when interpolating text-decoration-color. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/animations/interpolation/text-decoration-color-interpolation-expected.txt ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index d3d2cf1423527d3b36eeefdadf05865218f19c96..fd3f8f58a42450e6a5755064afa70f137f754a5b 100644

--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -433,7 +433,7 @@ PassRefPtrWillBeRawPtr<AnimatableValue> CSSAnimatableValueFactory::create(CSSPro

style.svgStyle().strokePaintColor(), style.svgStyle().visitedLinkStrokePaintColor(),

style.svgStyle().strokePaintUri(), style.svgStyle().visitedLinkStrokePaintUri());

case CSSPropertyTextDecorationColor:

- return AnimatableColor::create(style.textDecorationColor().resolve(style.color()), style.visitedLinkTextDecorationColor().resolve(style.visitedLinkColor()));

+ return createFromColor(property, style);

case CSSPropertyTextIndent:

return createFromLength(style.textIndent(), style);

case CSSPropertyTextShadow: