Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6720)

Unified Diff: chrome/browser/ui/browser.h

Issue 7461059: Fullscreen JS API implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: respond to comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/browser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index b4c98c9173edebbce7419eb1e347c97530873d0b..62d5d4df703c3de77edffef6030e0237f82ee8bf 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -880,6 +880,8 @@ class Browser : public TabHandlerDelegate,
virtual void DidNavigateToPendingEntry(TabContents* tab) OVERRIDE;
virtual content::JavaScriptDialogCreator*
GetJavaScriptDialogCreator() OVERRIDE;
+ virtual void ToggleFullscreenModeForRVH(TabContents* tab,
Peter Kasting 2011/08/15 22:42:54 Nit: Since this function takes a TabContents*, it
koz (OOO until 15th September) 2011/08/16 07:06:55 Done.
+ bool enter_fullscreen) OVERRIDE;
// Overridden from TabContentsWrapperDelegate:
virtual void OnDidGetApplicationInfo(TabContentsWrapper* source,
@@ -1126,6 +1128,14 @@ class Browser : public TabHandlerDelegate,
// BrowserWindow if necessary.
void UpdateBookmarkBarState(BookmarkBarStateChangeReason reason);
+ // Make the current tab exit fullscreen mode. If the browser was fullscreen
+ // because of that (as opposed to the user clicking the fullscreen button)
+ // then take the browser out of fullscreen mode as well.
+ void ExitTabbedFullscreenMode();
Peter Kasting 2011/08/15 22:42:54 Nit: I think adding "IfNecessary" to both these fu
koz (OOO until 15th September) 2011/08/16 07:06:55 Done.
+
+ // Notifies the tab that it has been forced out of fullscreen mode.
+ void NotifyTabOfFullscreenExit();
+
// Data members /////////////////////////////////////////////////////////////
NotificationRegistrar registrar_;
@@ -1265,6 +1275,13 @@ class Browser : public TabHandlerDelegate,
BookmarkBar::State bookmark_bar_state_;
+ // Whether the current tab should be notified if the browser exits
+ // fullscreen.
+ bool notify_tab_of_fullscreen_exit_;
+
+ // True if the current tab is in fullscreen mode.
+ bool tab_caused_fullscreen_;
+
DISALLOW_COPY_AND_ASSIGN(Browser);
};
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/browser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698