Chromium Code Reviews
Help | Chromium Project | Sign in
(101)

Issue 7461059: Fullscreen JS API implementation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by koz
Modified:
2 years, 7 months ago
CC:
chromium-reviews_chromium.org, joi+watch-content_chromium.org, jam, jeremya, schechter
Visibility:
Public.

Description

Fullscreen JS API implementation.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98193

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2

Patch Set 3 : responded to sky's comment #

Total comments: 10

Patch Set 4 : respond to comments #

Total comments: 13

Patch Set 5 : respond to comments #

Patch Set 6 : respond to comments #

Patch Set 7 : rebased #

Patch Set 8 : windows work #

Patch Set 9 : minor behvaioural enhancements #

Patch Set 10 : make ctrl-tab exit JS fullscreen mode #

Total comments: 10

Patch Set 11 : respond to comments #

Total comments: 19

Patch Set 12 : respond to comments #

Total comments: 4

Patch Set 13 : respond to comments #

Patch Set 14 : respond to comments #

Total comments: 1

Patch Set 15 : rebase #

Patch Set 16 : add test #

Total comments: 4

Patch Set 17 : whitespace #

Patch Set 18 : fix test #

Patch Set 19 : fix test #

Patch Set 20 : remove commented out code #

Total comments: 6

Patch Set 21 : add test #

Patch Set 22 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -4 lines) Lint Patch
M chrome/browser/ui/browser.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 6 chunks +40 lines, -1 line 0 comments ? errors Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 7 chunks +47 lines, -2 lines 0 comments ? errors Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +30 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M chrome/common/chrome_notification_types.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M content/browser/renderer_host/render_view_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments ? errors Download
M content/browser/renderer_host/render_view_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +7 lines, -0 lines 0 comments ? errors Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments ? errors Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +5 lines, -0 lines 0 comments ? errors Download
M content/browser/tab_contents/tab_contents_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M content/browser/tab_contents/tab_contents_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M content/common/view_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +8 lines, -0 lines 0 comments ? errors Download
M content/renderer/render_view.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +3 lines, -0 lines 0 comments ? errors Download
M content/renderer/render_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +14 lines, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 46
koz
Hi all, This is a proof of concept for implementing a the JS fullscreen API ...
2 years, 8 months ago #1
Peter Kasting
You assigned four reviewers. Can you say what you wanted each to look at?
2 years, 8 months ago #2
koz
I ran this idea before Andrew before writing this patch and he suggested the people ...
2 years, 8 months ago #3
Peter Kasting
On 2011/07/27 18:46:41, koz wrote: > My intent was to see if any of you ...
2 years, 8 months ago #4
koz
On 2011/07/27 18:56:05, Peter Kasting wrote: > On 2011/07/27 18:46:41, koz wrote: > > My ...
2 years, 8 months ago #5
koz
[-pkasting, +sky]
2 years, 8 months ago #6
sky
http://codereview.chromium.org/7461059/diff/2001/content/browser/renderer_host/render_view_host.cc File content/browser/renderer_host/render_view_host.cc (right): http://codereview.chromium.org/7461059/diff/2001/content/browser/renderer_host/render_view_host.cc#newcode970 content/browser/renderer_host/render_view_host.cc:970: content::GetContentClient()->browser()->EnterFullscreenMode(); ContentClient isn't intended for this sort of call. ...
2 years, 8 months ago #7
koz
Thanks, sky! http://codereview.chromium.org/7461059/diff/2001/content/browser/renderer_host/render_view_host.cc File content/browser/renderer_host/render_view_host.cc (right): http://codereview.chromium.org/7461059/diff/2001/content/browser/renderer_host/render_view_host.cc#newcode970 content/browser/renderer_host/render_view_host.cc:970: content::GetContentClient()->browser()->EnterFullscreenMode(); On 2011/07/28 00:45:54, sky wrote: > ...
2 years, 8 months ago #8
sky
http://codereview.chromium.org/7461059/diff/8002/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): http://codereview.chromium.org/7461059/diff/8002/chrome/browser/ui/browser.h#newcode504 chrome/browser/ui/browser.h:504: void EnterFullscreenMode(); These should be with the other TabContentsDelegate ...
2 years, 8 months ago #9
koz
http://codereview.chromium.org/7461059/diff/8002/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): http://codereview.chromium.org/7461059/diff/8002/chrome/browser/ui/browser.h#newcode504 chrome/browser/ui/browser.h:504: void EnterFullscreenMode(); On 2011/07/28 03:53:29, sky wrote: > These ...
2 years, 8 months ago #10
sky
http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h File content/browser/renderer_host/render_view_host_delegate.h (right): http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h#newcode361 content/browser/renderer_host/render_view_host_delegate.h:361: // Puts the browser into fullscreen mode, focussing on ...
2 years, 8 months ago #11
scherkus
I've got some nits on naming but don't wait on me to land this patch ...
2 years, 8 months ago #12
sky
http://codereview.chromium.org/7461059/diff/14001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/14001/chrome/browser/ui/browser.cc#newcode3481 chrome/browser/ui/browser.cc:3481: if (window_->IsFullscreen()) On 2011/07/28 22:43:08, scherkus wrote: > are ...
2 years, 8 months ago #13
koz
http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h File content/browser/renderer_host/render_view_host_delegate.h (right): http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h#newcode361 content/browser/renderer_host/render_view_host_delegate.h:361: // Puts the browser into fullscreen mode, focussing on ...
2 years, 8 months ago #14
sky
http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h File content/browser/renderer_host/render_view_host_delegate.h (right): http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h#newcode361 content/browser/renderer_host/render_view_host_delegate.h:361: // Puts the browser into fullscreen mode, focussing on ...
2 years, 8 months ago #15
koz
http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h File content/browser/renderer_host/render_view_host_delegate.h (right): http://codereview.chromium.org/7461059/diff/8002/content/browser/renderer_host/render_view_host_delegate.h#newcode361 content/browser/renderer_host/render_view_host_delegate.h:361: // Puts the browser into fullscreen mode, focussing on ...
2 years, 8 months ago #16
sky
LGTM
2 years, 8 months ago #17
koz
On 2011/08/01 14:03:47, sky wrote: > LGTM sky could I get you to take another ...
2 years, 8 months ago #18
koz
On 2011/08/09 00:56:38, koz wrote: > On 2011/08/01 14:03:47, sky wrote: > > LGTM > ...
2 years, 8 months ago #19
Peter Kasting
I can try and look at this tomorrow. I think banning tab switching while fullscreened ...
2 years, 8 months ago #20
koz
On 2011/08/11 01:12:25, Peter Kasting wrote: > I can try and look at this tomorrow. ...
2 years, 8 months ago #21
Peter Kasting
In one of my comments below I condense a pair of enter/exit functions into a ...
2 years, 8 months ago #22
koz
Thanks, Peter. I took your advice and merged the Enter/Exit functions into one with a ...
2 years, 8 months ago #23
Peter Kasting
On 2011/08/15 05:50:26, koz wrote: > I've changed the behaviour here so that instead of ...
2 years, 8 months ago #24
koz
On 2011/08/15 17:51:28, Peter Kasting wrote: > On 2011/08/15 05:50:26, koz wrote: > > I've ...
2 years, 8 months ago #25
Ben Goodger (Google)
http://codereview.chromium.org/7461059/diff/42001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/42001/chrome/browser/ui/browser.cc#newcode1527 chrome/browser/ui/browser.cc:1527: ExitTabbedFullscreenMode(); For all of these... these aren't the only ...
2 years, 8 months ago #26
Peter Kasting
Ben's comments about where to listen for tab changes seem pretty critical. Other stuff LGTM. ...
2 years, 8 months ago #27
koz
http://codereview.chromium.org/7461059/diff/42001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/42001/chrome/browser/ui/browser.cc#newcode1527 chrome/browser/ui/browser.cc:1527: ExitTabbedFullscreenMode(); On 2011/08/15 22:37:12, Ben Goodger (Google) wrote: > ...
2 years, 8 months ago #28
Peter Kasting
http://codereview.chromium.org/7461059/diff/48001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/48001/chrome/browser/ui/browser.cc#newcode3147 chrome/browser/ui/browser.cc:3147: int active_index = tab_handler_->GetTabStripModel()->active_index(); Nit: This variable seems unused? ...
2 years, 8 months ago #29
koz
http://codereview.chromium.org/7461059/diff/48001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/48001/chrome/browser/ui/browser.cc#newcode3147 chrome/browser/ui/browser.cc:3147: int active_index = tab_handler_->GetTabStripModel()->active_index(); On 2011/08/16 18:04:43, Peter Kasting ...
2 years, 8 months ago #30
Peter Kasting
Any particular reason you switched |notify_on_fullscreen_exit_| from a bool to a TCW*? It seems like ...
2 years, 8 months ago #31
koz
On 2011/08/17 17:36:22, Peter Kasting wrote: > Any particular reason you switched |notify_on_fullscreen_exit_| from a ...
2 years, 8 months ago #32
Peter Kasting
On 2011/08/17 21:51:34, koz wrote: > On 2011/08/17 17:36:22, Peter Kasting wrote: > > Any ...
2 years, 8 months ago #33
koz
On 2011/08/17 21:55:24, Peter Kasting wrote: > On 2011/08/17 21:51:34, koz wrote: > > On ...
2 years, 8 months ago #34
Peter Kasting
LGTM with one question http://codereview.chromium.org/7461059/diff/58001/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/58001/chrome/browser/ui/browser.cc#newcode2929 chrome/browser/ui/browser.cc:2929: ExitTabbedFullscreenModeIfNecessary(); I wonder if it ...
2 years, 8 months ago #35
I haz the power (commit-bot)
Presubmit check for 7461059-60001 failed and returned exit status 1. Running presubmit commit checks ...
2 years, 8 months ago #36
koz
On 2011/08/23 06:42:55, I haz the power (commit-bot) wrote: > Presubmit check for 7461059-60001 failed ...
2 years, 8 months ago #37
Ben Goodger (Google)
Do you have any tests for this behavior? If not, you should.
2 years, 8 months ago #38
koz
On 2011/08/23 16:07:21, Ben Goodger (Google) wrote: > Do you have any tests for this ...
2 years, 7 months ago #39
brettw
LGTM http://codereview.chromium.org/7461059/diff/65001/content/browser/tab_contents/tab_contents_delegate.cc File content/browser/tab_contents/tab_contents_delegate.cc (right): http://codereview.chromium.org/7461059/diff/65001/content/browser/tab_contents/tab_contents_delegate.cc#newcode284 content/browser/tab_contents/tab_contents_delegate.cc:284: bool enter_fullscreen) { Align to TabContents. http://codereview.chromium.org/7461059/diff/65001/content/browser/tab_contents/tab_contents_delegate.h File ...
2 years, 7 months ago #40
koz
http://codereview.chromium.org/7461059/diff/65001/content/browser/tab_contents/tab_contents_delegate.cc File content/browser/tab_contents/tab_contents_delegate.cc (right): http://codereview.chromium.org/7461059/diff/65001/content/browser/tab_contents/tab_contents_delegate.cc#newcode284 content/browser/tab_contents/tab_contents_delegate.cc:284: bool enter_fullscreen) { On 2011/08/24 00:28:31, brettw wrote: > ...
2 years, 7 months ago #41
Ben Goodger (Google)
http://codereview.chromium.org/7461059/diff/66019/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/66019/chrome/browser/ui/browser.cc#newcode1280 chrome/browser/ui/browser.cc:1280: FROM_HERE, method_factory_.NewRunnableMethod( 4-space indents here http://codereview.chromium.org/7461059/diff/66019/chrome/browser/ui/browser.cc#newcode1286 chrome/browser/ui/browser.cc:1286: chrome::NOTIFICATION_FULLSCREEN_CHANGED, and ...
2 years, 7 months ago #42
koz
http://codereview.chromium.org/7461059/diff/66019/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/7461059/diff/66019/chrome/browser/ui/browser.cc#newcode1280 chrome/browser/ui/browser.cc:1280: FROM_HERE, method_factory_.NewRunnableMethod( On 2011/08/24 18:21:49, Ben Goodger (Google) wrote: ...
2 years, 7 months ago #43
Ben Goodger (Google)
LGTM
2 years, 7 months ago #44
I haz the power (commit-bot)
Can't apply patch for file chrome/browser/ui/browser.h. While running patch -p1 --forward --force; patching file chrome/browser/ui/browser.h ...
2 years, 7 months ago #45
I haz the power (commit-bot)
2 years, 7 months ago #46
Change committed as 98193
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6