Fullscreen JS API implementation.

content/browser/renderer_host/render_view_host_delegate.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 340 matching lines @@
   virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event) {}
 
   // Notifications about mouse events in this view.  This is useful for
   // implementing global 'on hover' features external to the view.
   virtual void HandleMouseMove() {}
   virtual void HandleMouseDown() {}
   virtual void HandleMouseLeave() {}
   virtual void HandleMouseUp() {}
   virtual void HandleMouseActivate() {}
 
+  // Puts the browser into fullscreen mode, focussing on this tab.

[sky, 2011/07/28 03:53:29]

This description makes it sound as though you intended to make Browser select
the tab that invoked it. Your implementation in Browser doesn't select the tab
though. Did you want to?

[koz (OOO until 15th September), 2011/07/28 05:14:30]

I think so. What exactly does 'select the tab' mean in this context? This
function will be called by a JS API (webkitRequestFullScreen()) triggered by a
user gesture on a page and I want that page to be fullscreened. What changes
would I need to make to my implementation to achieve that?

[sky, 2011/07/28 16:07:02]

The tabstrip has a bunch of tabs, but only one active (the one whose content you
see). In Browser you can make a tab active by way of ActivateContents.

[koz (OOO until 15th September), 2011/07/29 04:12:57]

Is it necessary to call ActivateContents() if this call can only be triggered by
a user gesture? Does that not imply that the tab in question would already be
active?

I've added a call to ActivateContents() to TabContents before it delegates to
TabContentsDelegate (ie: Browser) to activate the tab that the JS call was made
from, is that ok?

[sky, 2011/07/29 15:51:46]

With the IPC calls it might be possible for a user to switch tabs before the JS
is processed. Probably pretty unlikely though.
If you're going to activate the tab, I think that is best done in Browser, not
TabContents. But, I'm fine with you not activating at all. I only raised this
because your comments in TabContentsDelegate say 'focussing on this tab' which
implies it's calling activate.

[koz (OOO until 15th September), 2011/08/01 03:43:38]

Ah, I see. I'll rephrase the comment and remove the call to Activate(). Sorry
for the confusion!

+  virtual void EnterFullscreenMode() {}
+
+  // Makes the browser exit fullscreen mode.
+  virtual void ExitFullscreenMode() {}
+
  protected:
   virtual ~RenderViewHostDelegate() {}
 };
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_