Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: src/type-info.h

Issue 7461026: Record ToBoolean's type information in Hydrogen's HBranch instruction, so we can use it in LCodeG... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/type-info.h
===================================================================
--- src/type-info.h (revision 8716)
+++ src/type-info.h (working copy)
@@ -238,6 +238,10 @@
bool LoadIsBuiltin(Property* expr, Builtins::Name id);
+ // We can't use ToBooleanStub::Types as the return value because of various
+ // cylces in our headers. Death to tons of implementations in headers!! :-P
fschneider 2011/07/25 11:55:19 It would be a perfect opportunity to untangle one
Sven Panne 2011/07/25 14:06:32 Untangling our huge header mess is a separate task
+ byte ToBooleanTypes(unsigned ast_id);
+
// Get type information for arithmetic operations and compares.
TypeInfo UnaryType(UnaryOperation* expr);
TypeInfo BinaryType(BinaryOperation* expr);

Powered by Google App Engine
This is Rietveld 408576698