Record ToBoolean's type information in Hydrogen's HBranch instruction, so we can use it in LCodeG...

src/type-info.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 220 matching lines @@
                                  Handle<String> name,
                                  CallKind call_kind);
   void CollectKeyedReceiverTypes(unsigned ast_id,
                                  ZoneMapList* types);
 
   CheckType GetCallCheckType(Call* expr);
   Handle<JSObject> GetPrototypeForPrimitiveCheck(CheckType check);
 
   bool LoadIsBuiltin(Property* expr, Builtins::Name id);
 
+  // We can't use ToBooleanStub::Types as the return value because of various
+  // cylces in our headers. Death to tons of implementations in headers!! :-P

[fschneider, 2011/07/25 11:55:19]

It would be a perfect opportunity to untangle one of the cycles!

If you add the comment, please add a todo with a corresponding issue to track.
Otherwise, it will never happen ;)

[Sven Panne, 2011/07/25 14:06:32]

Untangling our huge header mess is a separate task which will require a few
days, probably even weeks. I've tried some seemingly innocuous cleanups several
times and almost always completely reverted after half a day or so. Firing up
doxygen on our sources, switching the browser to full-screen and admiring the
enormous header dependency graphs should convince anyone that this cleanup task
is not a minor one... ;-)

I'll add a TODO here.

+  byte ToBooleanTypes(unsigned ast_id);
+
   // Get type information for arithmetic operations and compares.
   TypeInfo UnaryType(UnaryOperation* expr);
   TypeInfo BinaryType(BinaryOperation* expr);
   TypeInfo CompareType(CompareOperation* expr);
   bool IsSymbolCompare(CompareOperation* expr);
   TypeInfo SwitchType(CaseClause* clause);
   TypeInfo IncrementType(CountOperation* expr);
 
  private:
   ZoneMapList* CollectReceiverTypes(unsigned ast_id,
@@ skipping 17 matching lines @@
 
   Handle<Context> global_context_;
   Handle<NumberDictionary> dictionary_;
 
   DISALLOW_COPY_AND_ASSIGN(TypeFeedbackOracle);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_TYPE_INFO_H_