Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 745963002: harmony-scoping: Disallow cross-script assignment to const (Closed)

Created:
6 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

harmony-scoping: Disallow cross-script assignment to const R=rossberg@chromium.org BUG=v8:2198 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-decls.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 1 month ago (2014-11-20 23:56:50 UTC) #1
rossberg
lgtm
6 years, 1 month ago (2014-11-21 08:23:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745963002/1
6 years, 1 month ago (2014-11-21 17:49:53 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 18:09:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698