src/hydrogen.cc - Issue 745963002: harmony-scoping: Disallow cross-script assignment to const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 745963002: harmony-scoping: Disallow cross-script assignment to const (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 46a3810c75e840f16b9039d86ab9219962e761df..3044622fa35a18265fb9dd696df6a13f7ab64fbf 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -6556,6 +6556,9 @@ void HOptimizedGraphBuilder::HandleGlobalVariableAssignment(

global->native_context()->script_context_table());

ScriptContextTable::LookupResult lookup;

if (ScriptContextTable::Lookup(script_contexts, var->name(), &lookup)) {

+ if (lookup.mode == CONST) {

+ return Bailout(kNonInitializerAssignmentToConst);

+ }

Handle<Context> script_context =

ScriptContextTable::GetContext(script_contexts, lookup.context_index);

HStoreNamedField* instr = Add<HStoreNamedField>(

« no previous file with comments | « no previous file | test/cctest/test-decls.cc » ('j') | no next file with comments »