Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2302)

Unified Diff: build/android/pylib/base/test_run_factory.py

Issue 745793002: Add AMP support to test runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments on previous patch set Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/base/test_run_factory.py
diff --git a/build/android/pylib/base/test_run_factory.py b/build/android/pylib/base/test_run_factory.py
index 50a9690bc4ff0201066f2c16f94b50215189233f..9e4e40fbe3a9b215a3e14d39da408ae3ccd6fca4 100644
--- a/build/android/pylib/base/test_run_factory.py
+++ b/build/android/pylib/base/test_run_factory.py
@@ -2,8 +2,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-def CreateTestRun(_options, _env, _test_instance, error_func):
+import logging
+
+from pylib.remote.device import remote_device_gtest_run
+from pylib.remote.device import remote_device_uirobot_run
+def CreateTestRun(_options, _env, _test_instance, error_func):
jbudorick 2014/12/03 22:46:09 Once you start using a parameter, you should remov
rnephew (Reviews Here) 2014/12/03 23:49:25 Done.
+ if (_options.environment == 'remote_device' and
jbudorick 2014/12/03 22:46:09 Why check if options.environment == 'remote_device
rnephew (Reviews Here) 2014/12/03 23:49:25 Done.
+ _test_instance.TestType() == 'gtest'):
+ return remote_device_gtest_run.RemoteDeviceGtestRun(_env, _test_instance)
+ if (_options.environment == 'remote_device' and
+ _test_instance.TestType() == 'uirobot'):
+ return remote_device_uirobot_run.RemoteDeviceUirobotRun(
+ _env,_test_instance)
# TODO(jbudorick) Add local gtest test runs
# TODO(jbudorick) Add local instrumentation test runs.
error_func('No test runs are currently supported.')

Powered by Google App Engine
This is Rietveld 408576698