build/android/pylib/base/test_run_factory.py - Issue 745793002: Add AMP support to test runner.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/base/test_run_factory.py

Issue 745793002: Add AMP support to test runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments on previous patch set Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/android/pylib/base/test_instance_factory.py ('k') | build/android/pylib/constants.py » ('j') | build/android/pylib/remote/device/remote_device_environment.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

	5 import logging

	6

	7 from pylib.remote.device import remote_device_gtest_run

	8 from pylib.remote.device import remote_device_uirobot_run

	9

5 def CreateTestRun(_options, _env, _test_instance, error_func):	10 def CreateTestRun(_options, _env, _test_instance, error_func):
	jbudorick 2014/12/03 22:46:09 Once you start using a parameter, you should remov Once you start using a parameter, you should remove the underscore. Here, all 3 leading underscores can be removed. rnephew (Reviews Here) 2014/12/03 23:49:25 Done. Show quoted text On 2014/12/03 22:46:09, jbudorick wrote: > Once you start using a parameter, you should remove the underscore. Here, all 3 > leading underscores can be removed. Done.
6	11 if (_options.environment == 'remote_device' and
	jbudorick 2014/12/03 22:46:09 Why check if options.environment == 'remote_device Why check if options.environment == 'remote_device' twice? Why not nested ifs? rnephew (Reviews Here) 2014/12/03 23:49:25 Done. Show quoted text On 2014/12/03 22:46:09, jbudorick wrote: > Why check if options.environment == 'remote_device' twice? Why not nested ifs? Done.
	12 _test_instance.TestType() == 'gtest'):

	13 return remote_device_gtest_run.RemoteDeviceGtestRun(_env, _test_instance)

	14 if (_options.environment == 'remote_device' and

	15 _test_instance.TestType() == 'uirobot'):

	16 return remote_device_uirobot_run.RemoteDeviceUirobotRun(

	17 _env,_test_instance)

7 # TODO(jbudorick) Add local gtest test runs	18 # TODO(jbudorick) Add local gtest test runs

8 # TODO(jbudorick) Add local instrumentation test runs.	19 # TODO(jbudorick) Add local instrumentation test runs.

9 error_func('No test runs are currently supported.')	20 error_func('No test runs are currently supported.')

10	21

OLD	NEW