Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 745663002: Adding GeometryData object (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/gpu/GrGeometryData.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
I debated putting the implementations of new and delete and the TLS machinery in a ...
6 years, 1 month ago (2014-11-20 16:06:32 UTC) #2
joshualitt
On 2014/11/20 16:06:32, joshualitt wrote: > I debated putting the implementations of new and delete ...
6 years, 1 month ago (2014-11-20 17:18:54 UTC) #3
bsalomon
I think these should share the same pool as the processors
6 years, 1 month ago (2014-11-20 17:45:49 UTC) #4
joshualitt
On 2014/11/20 17:45:49, bsalomon wrote: > I think these should share the same pool as ...
6 years, 1 month ago (2014-11-20 20:24:17 UTC) #5
bsalomon
lgtm
6 years, 1 month ago (2014-11-20 22:17:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745663002/20001
6 years, 1 month ago (2014-11-20 22:41:43 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 22:50:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c07379d6b1a02ddbf1a5fd9518696b3737067532

Powered by Google App Engine
This is Rietveld 408576698