Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 745533002: Support native extensions for analysis and docgen. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support native extensions for analysis and docgen. BUG=http://dartbug.com/10616 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41903

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -69 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 3 chunks +25 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 4 chunks +16 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors/analyze.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + pkg/docgen/test/native_extensions_test.dart View 4 chunks +23 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-21 13:21:06 UTC) #2
floitsch
LGTM! https://codereview.chromium.org/745533002/diff/1/pkg/compiler/lib/src/apiimpl.dart File pkg/compiler/lib/src/apiimpl.dart (right): https://codereview.chromium.org/745533002/diff/1/pkg/compiler/lib/src/apiimpl.dart#newcode101 pkg/compiler/lib/src/apiimpl.dart:101: "--allow-native-extensions is only supported with in combination " ...
6 years, 1 month ago (2014-11-21 13:26:11 UTC) #3
Johnni Winther
https://codereview.chromium.org/745533002/diff/1/pkg/compiler/lib/src/apiimpl.dart File pkg/compiler/lib/src/apiimpl.dart (right): https://codereview.chromium.org/745533002/diff/1/pkg/compiler/lib/src/apiimpl.dart#newcode101 pkg/compiler/lib/src/apiimpl.dart:101: "--allow-native-extensions is only supported with in combination " On ...
6 years, 1 month ago (2014-11-21 13:51:15 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-21 14:10:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 41903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698