Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: Source/modules/geolocation/Geolocation.h

Issue 745503002: Replace Dictionary with PositionOptions in geolocation/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/Geolocation.h
diff --git a/Source/modules/geolocation/Geolocation.h b/Source/modules/geolocation/Geolocation.h
index eb8e4c6e7244f87a6c290573d41bca5c5ff2ae96..a94101787c5e5d8c9b9e4c527b1f52041aab7877 100644
--- a/Source/modules/geolocation/Geolocation.h
+++ b/Source/modules/geolocation/Geolocation.h
@@ -63,11 +63,11 @@ public:
// Creates a oneshot and attempts to obtain a position that meets the
// constraints of the options.
- void getCurrentPosition(PositionCallback*, PositionErrorCallback*, const Dictionary&);
+ void getCurrentPosition(PositionCallback*, PositionErrorCallback*, const PositionOptions&);
// Creates a watcher that will be notified whenever a new position is
// available that meets the constraints of the options.
- int watchPosition(PositionCallback*, PositionErrorCallback*, const Dictionary&);
+ int watchPosition(PositionCallback*, PositionErrorCallback*, const PositionOptions&);
// Removes all references to the watcher, it will not be updated again.
void clearWatch(int watchID);
@@ -156,7 +156,7 @@ private:
// fatal error if permission is denied or no position can be obtained.
void startRequest(GeoNotifier*);
- bool haveSuitableCachedPosition(PositionOptions*);
+ bool haveSuitableCachedPosition(const PositionOptions&);
// Runs the success callbacks for the set of notifiers awaiting a cached
// position, the set is then cleared. The oneshots are removed everywhere.

Powered by Google App Engine
This is Rietveld 408576698