Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: Source/modules/geolocation/GeoNotifier.cpp

Issue 745503002: Replace Dictionary with PositionOptions in geolocation/. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeoNotifier.cpp
diff --git a/Source/modules/geolocation/GeoNotifier.cpp b/Source/modules/geolocation/GeoNotifier.cpp
index f54f211bd457ca9f5a470b8d65caec7af7e93462..da88d300b096f0f90ecc41fc463fd953967692b3 100644
--- a/Source/modules/geolocation/GeoNotifier.cpp
+++ b/Source/modules/geolocation/GeoNotifier.cpp
@@ -11,7 +11,7 @@
namespace blink {
-GeoNotifier::GeoNotifier(Geolocation* geolocation, PositionCallback* successCallback, PositionErrorCallback* errorCallback, PositionOptions* options)
+GeoNotifier::GeoNotifier(Geolocation* geolocation, PositionCallback* successCallback, PositionErrorCallback* errorCallback, const PositionOptions& options)
// FIXME : m_geolocation should be removed, it makes circular dependancy.
: m_geolocation(geolocation)
, m_successCallback(successCallback)
@@ -22,7 +22,6 @@ GeoNotifier::GeoNotifier(Geolocation* geolocation, PositionCallback* successCall
{
ASSERT(m_geolocation);
ASSERT(m_successCallback);
- ASSERT(m_options);
}
void GeoNotifier::trace(Visitor* visitor)
@@ -30,7 +29,6 @@ void GeoNotifier::trace(Visitor* visitor)
visitor->trace(m_geolocation);
visitor->trace(m_successCallback);
visitor->trace(m_errorCallback);
- visitor->trace(m_options);
visitor->trace(m_fatalError);
}
@@ -67,7 +65,7 @@ void GeoNotifier::runErrorCallback(PositionError* error)
void GeoNotifier::startTimer()
{
- m_timer.startOneShot(m_options->timeout() / 1000.0, FROM_HERE);
+ m_timer.startOneShot(m_options.timeout() / 1000.0, FROM_HERE);
}
void GeoNotifier::stopTimer()

Powered by Google App Engine
This is Rietveld 408576698