Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Issue 745463002: Revert of Revert of ChromeBrowserProvider shouldn't own the FaviconService (Closed)

Created:
6 years, 1 month ago by kerz_google
Modified:
6 years, 1 month ago
Reviewers:
michaelbai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of ChromeBrowserProvider shouldn't own the FaviconService (patchset #1 id:1 of https://codereview.chromium.org/740853002/) Reason for revert: Reverted from the wrong branch. Original issue's description: > Revert of ChromeBrowserProvider shouldn't own the FaviconService (patchset #1 id:1 of https://codereview.chromium.org/731873003/) > > Reason for revert: > Broke the branch build. https://uberchromegw.corp.google.com/i/chrome.mobile/builders/arm%20stable/builds/7097 > > Original issue's description: > > ChromeBrowserProvider shouldn't own the FaviconService > > > > As FaviconService is KeyedService and will be deleted along with profile. > > > > BUG=411435 > > TBR=Tedchoc > > > > Review URL: https://codereview.chromium.org/739713002 > > > > Cr-Commit-Position: refs/heads/master@{#304690} > > > > Committed: https://chromium.googlesource.com/chromium/src/+/8c5b8c707daa9c026540a63f6f1e1c5981f5909c > > TBR=michaelbai@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=411435 > > Committed: https://crrev.com/fa4053cc550e8989991006ea59a171bc3dd8e6e3 > Cr-Commit-Position: refs/heads/master@{#304979} TBR=michaelbai@chromium.org NOTREECHECKS=true NOTRY=true BUG=411435 Committed: https://crrev.com/cc084e6c64f4650eabb814e0e9282ed816a86561 Cr-Commit-Position: refs/heads/master@{#304982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/browser/android/provider/chrome_browser_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 4 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kerz_google
Created Revert of Revert of ChromeBrowserProvider shouldn't own the FaviconService
6 years, 1 month ago (2014-11-20 05:06:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745463002/1
6 years, 1 month ago (2014-11-20 05:07:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 05:07:35 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 05:08:25 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc084e6c64f4650eabb814e0e9282ed816a86561
Cr-Commit-Position: refs/heads/master@{#304982}

Powered by Google App Engine
This is Rietveld 408576698