Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 745463002: Revert of Revert of ChromeBrowserProvider shouldn't own the FaviconService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 6 #define CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
7 7
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/android/scoped_java_ref.h" 9 #include "base/android/scoped_java_ref.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 const content::NotificationSource& source, 184 const content::NotificationSource& source,
185 const content::NotificationDetails& details) OVERRIDE; 185 const content::NotificationDetails& details) OVERRIDE;
186 186
187 JavaObjectWeakGlobalRef weak_java_provider_; 187 JavaObjectWeakGlobalRef weak_java_provider_;
188 188
189 Profile* profile_; 189 Profile* profile_;
190 BookmarkModel* bookmark_model_; 190 BookmarkModel* bookmark_model_;
191 history::TopSites* top_sites_; 191 history::TopSites* top_sites_;
192 192
193 scoped_ptr<AndroidHistoryProviderService> service_; 193 scoped_ptr<AndroidHistoryProviderService> service_;
194 scoped_ptr<FaviconService> favicon_service_;
195 194
196 base::CancelableTaskTracker cancelable_task_tracker_; 195 base::CancelableTaskTracker cancelable_task_tracker_;
197 196
198 // Used to register/unregister notification observer. 197 // Used to register/unregister notification observer.
199 content::NotificationRegistrar notification_registrar_; 198 content::NotificationRegistrar notification_registrar_;
200 199
201 bool handling_extensive_changes_; 200 bool handling_extensive_changes_;
202 201
203 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider); 202 DISALLOW_COPY_AND_ASSIGN(ChromeBrowserProvider);
204 }; 203 };
205 204
206 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_ 205 #endif // CHROME_BROWSER_ANDROID_PROVIDER_CHROME_BROWSER_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698