Source/core/rendering/svg/RenderSVGShape.h - Issue 745383007: Fix an issue where hit detection could fail on rect and ellipse shapes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGShape.h

Issue 745383007: Fix an issue where hit detection could fail on rect and ellipse shapes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/svg/RenderSVGEllipse.cpp ('K') | « Source/core/rendering/svg/RenderSVGRect.cpp ('k') | Source/core/rendering/svg/RenderSVGShape.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGShape.h

diff --git a/Source/core/rendering/svg/RenderSVGShape.h b/Source/core/rendering/svg/RenderSVGShape.h

index 11dbf4f86567537cc04e60e12d22ca008fa89547..764e239c76231a4bad87419555b9540e74bfbd51 100644

--- a/Source/core/rendering/svg/RenderSVGShape.h

+++ b/Source/core/rendering/svg/RenderSVGShape.h

@@ -83,6 +83,8 @@ protected:

virtual void updateShapeFromElement();

virtual bool shapeDependentStrokeContains(const FloatPoint&);

virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;

+ // Is the stroke "smooth"; that is, can we use simple geometry for hit testing

Erik Dahlström (inactive) 2014/12/03 15:16:35 That this has to be explained here indicates that

fs 2014/12/03 15:56:06 Maybe 'hasContinousStroke' instead? (and make it c

+ // or should we fall back to letting Skia handle the hit testing?

bool hasSmoothStroke() const;

// Give RenderSVGPath a hook for updating markers in updateShapeFromElement.

« Source/core/rendering/svg/RenderSVGEllipse.cpp ('K') | « Source/core/rendering/svg/RenderSVGRect.cpp ('k') | Source/core/rendering/svg/RenderSVGShape.cpp » ('j') | no next file with comments »