Fix an issue where hit detection could fail on rect and ellipse shapes

Source/core/rendering/svg/RenderSVGShape.h

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
  * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2006 Apple Computer, Inc
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * Copyright (C) 2011 University of Szeged
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 65 matching lines @@
 
     virtual ShapeGeometryCodePath geometryCodePath() const { return PathGeometry; }
     virtual const Vector<FloatPoint>* zeroLengthLineCaps() const { return 0; }
 
     virtual FloatRect objectBoundingBox() const override final { return m_fillBoundingBox; }
 
 protected:
     virtual void updateShapeFromElement();
     virtual bool shapeDependentStrokeContains(const FloatPoint&);
     virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;
+    // Is the stroke "smooth"; that is, can we use simple geometry for hit testing

[Erik Dahlström (inactive), 2014/12/03 15:16:35]

That this has to be explained here indicates that the method should be renamed
to make it more clear what it does.

[fs, 2014/12/03 15:56:06]

Maybe 'hasContinousStroke' instead? (and make it clear it's for non-<path>
shapes only.) It could also make sense to just specialize them per "primitive" -
since the requirements ought to be more lax for elllipes and circles than for
rects.

+    // or should we fall back to letting Skia handle the hit testing?
     bool hasSmoothStroke() const;
 
     // Give RenderSVGPath a hook for updating markers in updateShapeFromElement.
     virtual void processMarkerPositions() { };
 
     FloatRect m_fillBoundingBox;
     FloatRect m_strokeBoundingBox;
 
 private:
     // Hit-detection separated for the fill and the stroke
@@ skipping 24 matching lines @@
     bool m_needsBoundariesUpdate : 1;
     bool m_needsShapeUpdate : 1;
     bool m_needsTransformUpdate : 1;
 };
 
 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderSVGShape, isSVGShape());
 
 }
 
 #endif