Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 745383002: [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest. (Closed)

Created:
6 years, 1 month ago by nednguyen
Modified:
6 years ago
Reviewers:
tonyg, dtu, ernstm, slamm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest. These tests test logic of user_story_runner hence they should be moved to user_story_runner. In addition, the new tests use fake shared_user_story_state allows faster cycle time. Rename page_runner_unittest --> page_run_end_to_end_tests. BUG=434568 Committed: https://crrev.com/b709ad84c6002b17b1dfa57f811539f26f51f4cb Cr-Commit-Position: refs/heads/master@{#305328}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -865 lines) Patch
A + tools/telemetry/telemetry/page/page_run_end_to_end_tests.py View 4 chunks +1 line, -189 lines 0 comments Download
D tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +0 lines, -668 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner.py View 2 chunks +3 lines, -4 lines 2 comments Download
M tools/telemetry/telemetry/user_story/user_story_runner_unittest.py View 6 chunks +190 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
nednguyen
6 years, 1 month ago (2014-11-21 19:23:20 UTC) #2
nednguyen
On 2014/11/21 19:23:20, nednguyen wrote: On my linux workstation: Before: real 1m44.372s user 1m10.873s sys ...
6 years, 1 month ago (2014-11-21 19:28:37 UTC) #3
dtu
lgtm This is so great!
6 years, 1 month ago (2014-11-21 23:24:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/745383002/1
6 years, 1 month ago (2014-11-21 23:28:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-22 00:22:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b709ad84c6002b17b1dfa57f811539f26f51f4cb Cr-Commit-Position: refs/heads/master@{#305328}
6 years, 1 month ago (2014-11-22 00:23:32 UTC) #8
nednguyen
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/747283002/ by nednguyen@google.com. ...
6 years, 1 month ago (2014-11-22 04:20:12 UTC) #9
slamm
https://codereview.chromium.org/745383002/diff/1/tools/telemetry/telemetry/user_story/user_story_runner.py File tools/telemetry/telemetry/user_story/user_story_runner.py (right): https://codereview.chromium.org/745383002/diff/1/tools/telemetry/telemetry/user_story/user_story_runner.py#newcode246 tools/telemetry/telemetry/user_story/user_story_runner.py:246: user_story.display_name) This causes the exception to get printed twice. ...
6 years ago (2014-12-01 23:23:00 UTC) #11
nednguyen
6 years ago (2014-12-01 23:27:36 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/745383002/diff/1/tools/telemetry/telemetry/us...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/745383002/diff/1/tools/telemetry/telemetry/us...
tools/telemetry/telemetry/user_story/user_story_runner.py:246:
user_story.display_name)
On 2014/12/01 23:23:00, slamm wrote:
> This causes the exception to get printed twice.
> 
> Once here and once in results.AddValue.

Sure, feel free to remove this.

Powered by Google App Engine
This is Rietveld 408576698