tools/telemetry/telemetry/user_story/user_story_runner.py - Issue 745383002: [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner.py

Issue 745383002: [Telemetry] Move some tests from page_runner_unittest to user_story_runner_unittest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner_unittest.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/user_story/user_story_runner.py

diff --git a/tools/telemetry/telemetry/user_story/user_story_runner.py b/tools/telemetry/telemetry/user_story/user_story_runner.py

index 52f569d142a0f439b9472b33d766c187f75d97dc..98df04035ad57ee393684c279b19903e21eac363 100644

--- a/tools/telemetry/telemetry/user_story/user_story_runner.py

+++ b/tools/telemetry/telemetry/user_story/user_story_runner.py

@@ -111,10 +111,6 @@ def _RunUserStoryAndProcessErrorIfNeeded(

except page_action.PageActionNotSupported as e:

results.AddValue(

skip.SkipValue(user_story, 'Unsupported page action: %s' % e))

- except Exception:

- exception_formatter.PrintFormattedException(

- msg='Unhandled exception while running %s' % user_story.display_name)

- results.AddValue(failure.FailureValue(user_story, sys.exc_info()))

else:

if expectation == 'fail':

logging.warning(

@@ -245,6 +241,9 @@ def Run(test, user_story_set, expectations, finder_options, results):

except Exception:

# Tear down & restart the state for unhandled exceptions thrown by

# _RunUserStoryAndProcessErrorIfNeeded.

+ exception_formatter.PrintFormattedException(

+ msg='Unhandled exception while running %s' %

+ user_story.display_name)

slamm 2014/12/01 23:23:00 This causes the exception to get printed twice. O

nednguyen 2014/12/01 23:27:36 Sure, feel free to remove this.

results.AddValue(failure.FailureValue(user_story, sys.exc_info()))

state.TearDownState(results)

state = group.shared_user_story_state_class(