Removed refcounting from TextResourceDecoder

Removed refcounting from TextResourceDecoder

It's no longer needed anywhere, and this makes the transition to performing decoding on the parser thread more robust.

Builds on https://codereview.chromium.org/73293003/

R=abarth@chromium.org
BUG=277886
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162316

[abarth-chromium, 2013-11-18 06:50:47]

lgtm

Awesome!

[commit-bot: I haz the power, 2013-11-18 06:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/74493002/20001

[commit-bot: I haz the power, 2013-11-18 06:51:07]

Failed to apply patch for Source/core/dom/DecodedDataDocumentParser.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/DecodedDataDocumentParser.h
  Hunk #2 FAILED at 43.
  Hunk #3 FAILED at 58.
  2 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/DecodedDataDocumentParser.h.rej

Patch:       Source/core/dom/DecodedDataDocumentParser.h
Index: Source/core/dom/DecodedDataDocumentParser.h
diff --git a/Source/core/dom/DecodedDataDocumentParser.h
b/Source/core/dom/DecodedDataDocumentParser.h
index
58519f45ecd02eba7dbf4326d506b7eb6afa0eef..453147d0ecdbddad2e90e7e9cda345afa016b534
100644
--- a/Source/core/dom/DecodedDataDocumentParser.h
+++ b/Source/core/dom/DecodedDataDocumentParser.h
@@ -27,6 +27,7 @@
 #define DecodedDataDocumentParser_h
 
 #include "core/dom/DocumentParser.h"
+#include "wtf/OwnPtr.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
@@ -42,8 +43,8 @@ public:
     virtual void appendBytes(const char* bytes, size_t length) OVERRIDE;
     virtual void flush() OVERRIDE;
     virtual bool needsDecoder() const OVERRIDE { return !m_decoder; }
-    virtual void setDecoder(PassRefPtr<TextResourceDecoder>) OVERRIDE;
-    virtual PassRefPtr<TextResourceDecoder> decoder() OVERRIDE;
+    virtual void setDecoder(PassOwnPtr<TextResourceDecoder>) OVERRIDE;
+    virtual TextResourceDecoder* decoder() OVERRIDE;
     virtual void setHasAppendedData() OVERRIDE;
 
 protected:
@@ -57,7 +58,7 @@ private:
     void updateDocument(String& decodedData);
 
     bool m_hasAppendedData;
-    RefPtr<TextResourceDecoder> m_decoder;
+    OwnPtr<TextResourceDecoder> m_decoder;
 };
 
 }

[oystein (OOO til 10th of July), 2013-11-18 17:52:21]

On 2013/11/18 06:50:47, abarth wrote:
> lgtm
> 
> Awesome!

Thanks :)

Oh, I should've mentioned that this won't apply without
https://codereview.chromium.org/73293003/.

[commit-bot: I haz the power, 2013-11-19 01:55:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/74493002/20001

[commit-bot: I haz the power, 2013-11-19 01:55:10]

Failed to apply patch for Source/core/html/track/WebVTTParser.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/core/html/track/WebVTTParser.h
  |diff --git a/Source/core/html/track/WebVTTParser.h
b/Source/core/html/track/WebVTTParser.h
  |index
27e026883ecc54fd9dd363014b8a2dc3672f897c..b8ce7a8ee1feea156f2f25a0012eb2e3caa19c36
100644
  |--- a/Source/core/html/track/WebVTTParser.h
  |+++ b/Source/core/html/track/WebVTTParser.h
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/core/html/track/WebVTTParser.h
Index: Source/core/html/track/WebVTTParser.h
diff --git a/Source/core/html/track/WebVTTParser.h
b/Source/core/html/track/WebVTTParser.h
index
27e026883ecc54fd9dd363014b8a2dc3672f897c..b8ce7a8ee1feea156f2f25a0012eb2e3caa19c36
100644
--- a/Source/core/html/track/WebVTTParser.h
+++ b/Source/core/html/track/WebVTTParser.h
@@ -135,7 +135,7 @@ private:
     void skipWhiteSpace(const String&, unsigned*);
 
     BufferedLineReader m_lineReader;
-    RefPtr<TextResourceDecoder> m_decoder;
+    OwnPtr<TextResourceDecoder> m_decoder;
     String m_currentId;
     double m_currentStartTime;
     double m_currentEndTime;

[commit-bot: I haz the power, 2013-11-19 01:57:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/74493002/80002

[commit-bot: I haz the power, 2013-11-19 02:38:53]

Retried try job too often on linux_blink for step(s) blink_platform_unittests,
webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-19 19:19:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oysteine@chromium.org/74493002/320001

[commit-bot: I haz the power, 2013-11-19 20:50:14]

Change committed as 162316