Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 744793002: Reland and fix bug: Don't store redundant compile-type at values. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 41847)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -2051,8 +2051,15 @@
if ((representation() == kUnboxedInt32) && !CanDeoptimize()) {
converter->mark_truncating();
}
- flow_graph->InsertBefore(this, converter, env(), FlowGraph::kValue);
- return converter;
+ // Only replace if the replacement has CanDeoptimize is consistent with
+ // the original instructions. We may have removed environments already.
+ // Due to the way type propagation works currently, the CompileType of the
+ // converter input may not be the same (more general) than the information
+ // about the input of this unboxing instructions.
+ if (CanDeoptimize() == converter->CanDeoptimize()) {
+ flow_graph->InsertBefore(this, converter, env(), FlowGraph::kValue);
+ return converter;
+ }
}
}
« runtime/vm/flow_graph_compiler_ia32.cc ('K') | « runtime/vm/flow_graph_type_propagator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698