Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: extensions/renderer/i18n_custom_bindings.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/file_system_natives.cc ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/i18n_custom_bindings.cc
diff --git a/extensions/renderer/i18n_custom_bindings.cc b/extensions/renderer/i18n_custom_bindings.cc
index 9e99e1376d4fc88b616cfb1c1472e65bf07f7f21..762627088ef020edda6d8603b421177df45da93a 100644
--- a/extensions/renderer/i18n_custom_bindings.cc
+++ b/extensions/renderer/i18n_custom_bindings.cc
@@ -34,7 +34,7 @@ void I18NCustomBindings::GetL10nMessage(
if (args[2]->IsNull() || !args[2]->IsString()) {
return;
} else {
- extension_id = *v8::String::Utf8Value(args[2]->ToString());
+ extension_id = *v8::String::Utf8Value(args[2]);
if (extension_id.empty())
return;
}
@@ -73,13 +73,12 @@ void I18NCustomBindings::GetL10nMessage(
if (count > 9)
return;
for (uint32_t i = 0; i < count; ++i) {
- substitutions.push_back(
- *v8::String::Utf8Value(
- placeholders->Get(v8::Integer::New(isolate, i))->ToString()));
+ substitutions.push_back(*v8::String::Utf8Value(placeholders->Get(
+ v8::Integer::New(isolate, i))));
}
} else if (args[1]->IsString()) {
// chrome.i18n.getMessage("message_name", "one param");
- substitutions.push_back(*v8::String::Utf8Value(args[1]->ToString()));
+ substitutions.push_back(*v8::String::Utf8Value(args[1]));
}
args.GetReturnValue().Set(v8::String::NewFromUtf8(
« no previous file with comments | « extensions/renderer/file_system_natives.cc ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698