Ignore DevTools messages from the old inspected RVH after navigation

chrome/browser/devtools/devtools_ui_bindings.cc

Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 3abcde8a4f0500f0069617ae5f8153e30bcd5d86..aadbf567eea4ec29ef54f7563f0867b9d1231bdd 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -281,10 +281,9 @@ void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone(
 
 void DevToolsUIBindings::FrontendWebContentsObserver::
     AboutToNavigateRenderFrame(content::RenderFrameHost* render_frame_host) {
-  // TODO(creis): Create should be refactored to operate on RenderFrameHosts.
   devtools_bindings_->frontend_host_.reset(
-      content::DevToolsFrontendHost::Create(
-          render_frame_host->GetRenderViewHost(), devtools_bindings_));
+      content::DevToolsFrontendHost::Create(devtools_bindings_->web_contents(),

[dgozman, 2014/11/24 13:32:13]

If you create DevToolsFrontendHost for a WebContents instance, it should observe
render frame changes itself, and instantiate bindings in the main frame.
If you leave observing outside (as in this patch), perhaps DevToolsFrontendHost
should just enable bindings for a passed RenderFrameHost.

[yurys, 2014/11/24 14:08:54]

It will enable it for main frame only and it needs to handle IPC messages
addressed to the RFH so it needs to be a WebContentsObserver (RFH doesn't have
observers for handling messages) so I'd rather leave it as is.

+                                            devtools_bindings_));
 }
 
 void DevToolsUIBindings::FrontendWebContentsObserver::
@@ -369,8 +368,7 @@ DevToolsUIBindings::DevToolsUIBindings(content::WebContents* web_contents)
       DevToolsEmbedderMessageDispatcher::createForDevToolsFrontend(this));
 
   frontend_host_.reset(
-      content::DevToolsFrontendHost::Create(
-          web_contents_->GetRenderViewHost(), this));
+      content::DevToolsFrontendHost::Create(web_contents_, this));
 }
 
 DevToolsUIBindings::~DevToolsUIBindings() {