Ignore DevTools messages from the old inspected RVH after navigation

chrome/browser/devtools/devtools_ui_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 263 matching lines @@
       break;
     default:
       crashed = false;
       break;
   }
   devtools_bindings_->delegate_->RenderProcessGone(crashed);
 }
 
 void DevToolsUIBindings::FrontendWebContentsObserver::
     AboutToNavigateRenderFrame(content::RenderFrameHost* render_frame_host) {
-  // TODO(creis): Create should be refactored to operate on RenderFrameHosts.
   devtools_bindings_->frontend_host_.reset(
-      content::DevToolsFrontendHost::Create(
-          render_frame_host->GetRenderViewHost(), devtools_bindings_));
+      content::DevToolsFrontendHost::Create(devtools_bindings_->web_contents(),

[dgozman, 2014/11/24 13:32:13]

If you create DevToolsFrontendHost for a WebContents instance, it should observe
render frame changes itself, and instantiate bindings in the main frame.
If you leave observing outside (as in this patch), perhaps DevToolsFrontendHost
should just enable bindings for a passed RenderFrameHost.

[yurys, 2014/11/24 14:08:54]

It will enable it for main frame only and it needs to handle IPC messages
addressed to the RFH so it needs to be a WebContentsObserver (RFH doesn't have
observers for handling messages) so I'd rather leave it as is.

+                                            devtools_bindings_));
 }
 
 void DevToolsUIBindings::FrontendWebContentsObserver::
     DocumentOnLoadCompletedInMainFrame() {
   devtools_bindings_->DocumentOnLoadCompletedInMainFrame();
 }
 
 void DevToolsUIBindings::FrontendWebContentsObserver::
     DidNavigateMainFrame(const content::LoadCommittedDetails& details,
                          const content::FrameNavigateParams& params) {
@@ skipping 64 matching lines @@
   // Register on-load actions.
   registrar_.Add(
       this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
       content::Source<ThemeService>(
           ThemeServiceFactory::GetForProfile(profile_)));
 
   embedder_message_dispatcher_.reset(
       DevToolsEmbedderMessageDispatcher::createForDevToolsFrontend(this));
 
   frontend_host_.reset(
-      content::DevToolsFrontendHost::Create(
-          web_contents_->GetRenderViewHost(), this));
+      content::DevToolsFrontendHost::Create(web_contents_, this));
 }
 
 DevToolsUIBindings::~DevToolsUIBindings() {
   if (agent_host_.get())
     agent_host_->DetachClient();
 
   for (IndexingJobsMap::const_iterator jobs_it(indexing_jobs_.begin());
        jobs_it != indexing_jobs_.end(); ++jobs_it) {
     jobs_it->second->Stop();
   }
@@ skipping 509 matching lines @@
   if (frontend_loaded_)
     return;
   frontend_loaded_ = true;
 
   // Call delegate first - it seeds importants bit of information.
   delegate_->OnLoadCompleted();
 
   UpdateTheme();
   AddDevToolsExtensionsToClient();
 }