content/renderer/accessibility/blink_ax_enum_conversion.cc - Issue 744623002: Exposing ARIA state/property aria-orientation on Windows correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 744623002: Exposing ARIA state/property aria-orientation on Windows correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating aria-list on mac Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/shell/renderer/test_runner/web_ax_object_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_enum_conversion.cc

diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc

index 3f201cce3322857a5b6e564850b887af28386f80..e8ae1b04283854bd8f0ecdac795c171cbb970f20 100644

--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc

+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc

@@ -73,8 +73,13 @@ uint32 AXStateFromBlink(const blink::WebAXObject& o) {

if (o.isEnabled())

state |= (1 << ui::AX_STATE_ENABLED);

- if (o.isVertical())

- state |= (1 << ui::AX_STATE_VERTICAL);

+ blink::WebAXOrientation orientation = o.orientation();

+ if (orientation) {

dmazzoni 2014/11/29 07:48:19 Nit: I'd drop the if (orientation) check; it's not

+ if (orientation == blink::WebAXOrientationVertical)

+ state |= (1 << ui::AX_STATE_VERTICAL);

+ else if (orientation == blink::WebAXOrientationHorizontal)

+ state |= (1 << ui::AX_STATE_HORIZONTAL);

+ }

if (o.isVisited())

state |= (1 << ui::AX_STATE_VISITED);