Exposing ARIA state/property aria-orientation on Windows correctly.

content/renderer/accessibility/blink_ax_enum_conversion.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/accessibility/blink_ax_enum_conversion.h"
 
 #include "base/logging.h"
 
 namespace content {
 
@@ skipping 55 matching lines @@
 
   if (o.isSelected())
     state |= (1 << ui::AX_STATE_SELECTED);
 
   if (o.isVisited())
     state |= (1 << ui::AX_STATE_VISITED);
 
   if (o.isEnabled())
     state |= (1 << ui::AX_STATE_ENABLED);
 
-  if (o.isVertical())
-    state |= (1 << ui::AX_STATE_VERTICAL);
+  blink::WebAXOrientation orientation = o.orientation();
+  if (orientation) {

[dmazzoni, 2014/11/29 07:48:19]

Nit: I'd drop the if (orientation) check; it's not really necessary since you're
just comparing it to blink::WebAXOrientationVertical and
blink::WebAXOrientationHorizontal below.

+    if (orientation == blink::WebAXOrientationVertical)
+      state |= (1 << ui::AX_STATE_VERTICAL);
+    else if (orientation == blink::WebAXOrientationHorizontal)
+      state |= (1 << ui::AX_STATE_HORIZONTAL);
+  }
 
   if (o.isVisited())
     state |= (1 << ui::AX_STATE_VISITED);
 
   return state;
 }
 
 ui::AXRole AXRoleFromBlink(blink::WebAXRole role) {
   switch (role) {
     case blink::WebAXRoleAlert:
@@ skipping 304 matching lines @@
     case blink::WebAXTextDirectionBT:
       return ui::AX_TEXT_DIRECTION_BT;
     default:
       NOTREACHED();
   }
 
   return ui::AX_TEXT_DIRECTION_NONE;
 }
 
 }  // namespace content