Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 744623002: Exposing ARIA state/property aria-orientation on Windows correctly. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exposing ARIA state/property aria-orientation on Windows correctly. According to latest editor draft http://rawgit.com/w3c/aria/master/aria/aria.html#aria-orientation On windows aria orientation should be exposed as below ia2_states. IAccessible2: IA2_STATE_HORIZONTAL & IA2_STATE_VERTICAL This CL depends on https://codereview.chromium.org/730113003/ BUG=416763 Committed: https://crrev.com/c562d1d528441b80119252a6bd16f685990b7a29 Cr-Commit-Position: refs/heads/master@{#306154}

Patch Set 1 #

Patch Set 2 : updating #

Patch Set 3 : #

Patch Set 4 : Fixing mac bug #

Patch Set 5 : updating aria-list on mac #

Total comments: 1

Patch Set 6 : updating comments #

Patch Set 7 : fixing presubmit warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -40 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter_utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 chunks +9 lines, -13 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 3 4 5 6 2 chunks +7 lines, -8 lines 0 comments Download
M content/test/data/accessibility/aria-list.html View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria-list-expected-mac.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-orientation.html View 1 2 3 1 chunk +40 lines, -4 lines 0 comments Download
M content/test/data/accessibility/aria-orientation-expected-android.txt View 1 2 3 1 chunk +39 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria-orientation-expected-mac.txt View 1 2 3 1 chunk +39 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria-orientation-expected-win.txt View 1 2 3 1 chunk +39 lines, -3 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
shreeramk
Please review the changes. Thanks!!!
6 years ago (2014-11-28 08:28:42 UTC) #2
dmazzoni
lgtm This was a really great bug fix, well done. https://codereview.chromium.org/744623002/diff/80001/content/renderer/accessibility/blink_ax_enum_conversion.cc File content/renderer/accessibility/blink_ax_enum_conversion.cc (right): https://codereview.chromium.org/744623002/diff/80001/content/renderer/accessibility/blink_ax_enum_conversion.cc#newcode77 ...
6 years ago (2014-11-29 07:48:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744623002/100001
6 years ago (2014-11-30 15:15:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/27256)
6 years ago (2014-11-30 15:18:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744623002/120001
6 years ago (2014-12-01 05:02:10 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years ago (2014-12-01 06:00:08 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-01 06:00:48 UTC) #11
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c562d1d528441b80119252a6bd16f685990b7a29
Cr-Commit-Position: refs/heads/master@{#306154}

Powered by Google App Engine
This is Rietveld 408576698