Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: Source/core/rendering/RenderTable.cpp

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Avoid O(rows*cols) Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTable.cpp
diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp
index a5a90e380223bfb62aa2484c3ef5cabc7342914f..71a02d8c9873189f301453dbcd3b92dd44227067 100644
--- a/Source/core/rendering/RenderTable.cpp
+++ b/Source/core/rendering/RenderTable.cpp
@@ -393,6 +393,19 @@ void RenderTable::simplifiedNormalFlowLayout()
}
}
+bool RenderTable::recalcChildOverflowAfterStyleChange()
+{
+ ASSERT(childNeedsOverflowRecalcAfterStyleChange());
+ clearChildNeedsOverflowRecalcAfterStyleChange();
+
+ bool childrenOverflowChanged = false;
+ for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
+ if (section->childNeedsOverflowRecalcAfterStyleChange() && section->recalcChildOverflowAfterStyleChange())
+ childrenOverflowChanged = true;
Julien - ping for review 2014/11/25 18:33:10 This is better written: childrenOverflowChanged |
Xianzhu 2014/11/25 20:17:12 We still need to continue the loop to call recalcC
+ }
+ return childrenOverflowChanged;
+}
+
void RenderTable::layout()
{
ASSERT(needsLayout());

Powered by Google App Engine
This is Rietveld 408576698