Let RenderTable reach table cells needing overflow recalc

Source/core/rendering/RenderTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 375 matching lines @@
 }
 
 void RenderTable::simplifiedNormalFlowLayout()
 {
     for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
         section->layoutIfNeeded();
         section->computeOverflowFromCells();
     }
 }
 
+bool RenderTable::recalcChildOverflowAfterStyleChange()
+{
+    ASSERT(childNeedsOverflowRecalcAfterStyleChange());
+    clearChildNeedsOverflowRecalcAfterStyleChange();
+
+    bool childrenOverflowChanged = false;
+    for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
+        if (section->childNeedsOverflowRecalcAfterStyleChange() && section->recalcChildOverflowAfterStyleChange())
+            childrenOverflowChanged = true;

[Julien - ping for review, 2014/11/25 18:33:10]

This is better written:

childrenOverflowChanged |= section->childNeedsOverflowRecalcAfterStyleChange()
&& section->recalcChildOverflowAfterStyleChange();

However here, you don't need to continue if it's true:

if (section->childNeedsOverflowRecalcAfterStyleChange() &&
section->recalcChildOverflowAfterStyleChange())
    return true;

[Xianzhu, 2014/11/25 20:17:12]

We still need to continue the loop to call recalcChildOverflowAfterStyleChange
for other sections.

It seems that embedding section->recalcChildOverflowAfterStyleChange() in a
complex boolean expression let us think we are just calculating the boolean
result and overlook the real action.

Would this be better:

        if (!section->childNeedsOverflowRecalcAfterStyleChange())
            continue;
        if (section->recalcChildOverflowAfterStyleChange())
            childrenOverflowChanged = true;

+    }
+    return childrenOverflowChanged;
+}
+
 void RenderTable::layout()
 {
     ASSERT(needsLayout());
 
     if (simplifiedLayout())
         return;
 
     // Note: RenderTable is handled differently than other RenderBlocks and the LayoutScope
     //       must be created before the table begins laying out.
     TextAutosizer::LayoutScope textAutosizerLayoutScope(this);
@@ skipping 931 matching lines @@
 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCell* cell) const
 {
     ASSERT(cell->isFirstOrLastCellInRow());
     if (hasSameDirectionAs(cell->row()))
         return style()->borderEnd();
 
     return style()->borderStart();
 }
 
 }