LayoutTests/fast/table/outline-change-in-table-cell.html - Issue 744493002: Let RenderTable reach table cells needing overflow recalc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/table/outline-change-in-table-cell.html

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Avoid O(rows*cols) Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/table/outline-change-in-table-cell.html

diff --git a/LayoutTests/fast/table/outline-change-in-table-cell.html b/LayoutTests/fast/table/outline-change-in-table-cell.html

new file mode 100644

index 0000000000000000000000000000000000000000..2063a0c9ae8c3ce82f09b691ae1420de265cac66

--- /dev/null

+++ b/LayoutTests/fast/table/outline-change-in-table-cell.html

@@ -0,0 +1,24 @@

+<!DOCTYPE html>

+<script src="../repaint/resources/text-based-repaint.js"></script>

+<script>

+function repaintTest() {

+ var target = document.getElementById('target');

+ // Intermediate outline change should not affect final overflow and paint invalidation.

+ target.style.outline = '40px solid green';

+ target.offsetHeight;

+ target.style.outline = '20px solid green';

+ target.offsetHeight;

+onload = runRepaintTest;

+</script>

+<p style="height: 100px">

+Tests overflow recalc and paint invalidation in a table cell when outline changes.

+Passes if there is a thick green outline and no red.

Julien - ping for review 2014/11/25 18:33:10 The outline should be 20px for the test to pass as

Xianzhu 2014/11/25 20:17:12 Good catch. I changed the intermediate color to ye

+</p>

+<table style="border: none; margin: 50px">

+ <tr>

+ <td>

+ <div id="target" style="width: 100px; height: 100px; outline: 1px solid red"></div>

+ </td>

+ </tr>

+</table>