LayoutTests/fast/table/outline-change-in-table-cell.html - Issue 744493002: Let RenderTable reach table cells needing overflow recalc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/outline-change-in-table-cell.html

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Avoid O(rows*cols) Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/fast/table/outline-change-in-table-cell-expected.txt » ('j') | LayoutTests/fast/table/outline-change-in-table-cell-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../repaint/resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest() {

	5 var target = document.getElementById('target');

	6 // Intermediate outline change should not affect final overflow and paint inva lidation.

	7 target.style.outline = '40px solid green';

	8 target.offsetHeight;

	9 target.style.outline = '20px solid green';

	10 target.offsetHeight;

	11 }

	12 onload = runRepaintTest;

	13 </script>

	14 <p style="height: 100px">

	15 Tests overflow recalc and paint invalidation in a table cell when outline change s.

	16 Passes if there is a thick green outline and no red.
	Julien - ping for review 2014/11/25 18:33:10 The outline should be 20px for the test to pass as The outline should be 20px for the test to pass as you're doing 2 outline changes. Maybe it would be better to just do a thick one, following by a small one (2px) so that you can say that the test passes with a thin outline. Julien - ping for review 2014/11/25 18:33:10 The outline should be 20px for the test to pass as The outline should be 20px for the test to pass as you're doing 2 outline changes. Maybe it would be better to just do a thick one, following by a small one (2px) so that you can say that the test passes with a thin outline. Xianzhu 2014/11/25 20:17:12 Good catch. I changed the intermediate color to ye Show quoted text On 2014/11/25 18:33:10, Julien Chaffraix - PST wrote: > The outline should be 20px for the test to pass as you're doing 2 outline > changes. > > Maybe it would be better to just do a thick one, following by a small one (2px) > so that you can say that the test passes with a thin outline. Good catch. I changed the intermediate color to yellow to distinguish. 2px makes just 1px difference between the good and bad results which seems easy to be ignored by future rebaseliners when regression occurs.
	17 </p>

	18 <table style="border: none; margin: 50px">

	19 <tr>

	20 <td>

	21 <div id="target" style="width: 100px; height: 100px; outline: 1px solid re d"></div>

	22 </td>

	23 </tr>

	24 </table>

OLD	NEW