Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: LayoutTests/fast/table/outline-change-in-table-cell.html

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: RenderTableRow::recomputeOverflow Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/outline-change-in-table-cell.html
diff --git a/LayoutTests/fast/table/outline-change-in-table-cell.html b/LayoutTests/fast/table/outline-change-in-table-cell.html
new file mode 100644
index 0000000000000000000000000000000000000000..164f9d2572c2fe2302ee7fa703aba8a395989e84
--- /dev/null
+++ b/LayoutTests/fast/table/outline-change-in-table-cell.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<script src="../repaint/resources/text-based-repaint.js"></script>
+<script>
+function repaintTest() {
+ var target = document.getElementById('target');
+ // Intermediate outline change should not affect final overflow and paint invalidation.
+ target.style.outline = '40px solid yellow';
+ target.offsetHeight;
+ target.style.outline = '20px solid green';
+}
+onload = runRepaintTest;
+</script>
+<p style="height: 100px">
+Tests overflow recalc and paint invalidation in a table cell when outline changes.
+Passes if there is a thick green outline and no red.
Julien - ping for review 2014/12/03 19:44:36 And no yellow?
Xianzhu 2014/12/03 22:56:35 Done.
+</p>
+<table style="border: none; margin: 50px">
+ <tr>
+ <td>
Julien - ping for review 2014/12/03 19:44:36 Nit: you probably want to remove the 2px default p
Xianzhu 2014/12/03 22:56:35 Done.
+ <div id="target" style="width: 100px; height: 100px; outline: 1px solid red"></div>
+ </td>
+ </tr>
+</table>

Powered by Google App Engine
This is Rietveld 408576698