LayoutTests/fast/table/outline-change-in-table-cell.html - Issue 744493002: Let RenderTable reach table cells needing overflow recalc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/outline-change-in-table-cell.html

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: RenderTableRow::recomputeOverflow Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../repaint/resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest() {

	5 var target = document.getElementById('target');

	6 // Intermediate outline change should not affect final overflow and paint inva lidation.

	7 target.style.outline = '40px solid yellow';

	8 target.offsetHeight;

	9 target.style.outline = '20px solid green';

	10 }

	11 onload = runRepaintTest;

	12 </script>

	13 <p style="height: 100px">

	14 Tests overflow recalc and paint invalidation in a table cell when outline change s.

	15 Passes if there is a thick green outline and no red.
	Julien - ping for review 2014/12/03 19:44:36 And no yellow? And no yellow? Xianzhu 2014/12/03 22:56:35 Done. Show quoted text On 2014/12/03 19:44:36, Julien Chaffraix - PST wrote: > And no yellow? Done.
	16 </p>

	17 <table style="border: none; margin: 50px">

	18 <tr>

	19 <td>
	Julien - ping for review 2014/12/03 19:44:36 Nit: you probably want to remove the 2px default p Nit: you probably want to remove the 2px default padding on td's. Xianzhu 2014/12/03 22:56:35 Done. Show quoted text On 2014/12/03 19:44:36, Julien Chaffraix - PST wrote: > Nit: you probably want to remove the 2px default padding on td's. Done.
	20 <div id="target" style="width: 100px; height: 100px; outline: 1px solid re d"></div>

	21 </td>

	22 </tr>

	23 </table>

OLD	NEW