Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 744453002: Fix a bunch of Java Checkstyle issues. (Closed)

Created:
6 years, 1 month ago by aurimas (slooooooooow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, zea+watch_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, browser-components-watch_chromium.org, dmazzoni+watch_chromium.org, Ilya Sherman, tim+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, samuong+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, dyu1, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jochen+watch_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, klundberg+watch_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, jbudorick+watch_chromium.org, benquan, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, stgao, wjia+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a bunch of Java Checkstyle issues. BUG=318404 TBR=samuong@chromium.org Committed: https://crrev.com/cee75f0a7905c9e232900252142853a8b11d9701 Cr-Commit-Position: refs/heads/master@{#305047}

Patch Set 1 #

Total comments: 8

Patch Set 2 : ted's nits #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : Fix bad rebase #

Patch Set 5 : NeedsBraces to info #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -607 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwCookieManager.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java View 1 3 chunks +23 lines, -25 lines 0 comments Download
M base/android/java/src/org/chromium/base/CommandLine.java View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/java/src/org/chromium/base/LocaleUtils.java View 1 chunk +3 lines, -3 lines 0 comments Download
M base/android/java/src/org/chromium/base/MemoryPressureListener.java View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/ObserverList.java View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/PowerMonitor.java View 2 chunks +7 lines, -7 lines 0 comments Download
M base/android/java/src/org/chromium/base/ThreadUtils.java View 1 chunk +3 lines, -3 lines 0 comments Download
M base/android/java/src/org/chromium/base/TraceEvent.java View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/javatests/src/org/chromium/base/CommandLineTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/rezip/RezipApk.java View 4 chunks +10 lines, -16 lines 0 comments Download
M build/android/tests/multiple_proguards/src/dummy/DummyActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 2 chunks +65 lines, -65 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/SuggestionAnswerTest.java View 2 chunks +33 lines, -39 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarTestAnimationListener.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/test/webview_shell/java/src/org/chromium/chromedriver_webview_shell/Main.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessService.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChromiumLinkerParams.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentSettings.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 2 chunks +15 lines, -16 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java View 2 chunks +4 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/PepperPluginManager.java View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/VibrationProvider.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java View 5 chunks +25 lines, -26 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/GamepadList.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ClipboardTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java View 1 chunk +6 lines, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java View 2 chunks +12 lines, -13 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/GestureDetectorResetTest.java View 1 chunk +7 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java View 1 chunk +14 lines, -15 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 2 chunks +14 lines, -15 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 1 chunk +6 lines, -6 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaResourceGetterTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java View 4 chunks +20 lines, -20 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TestsJavaScriptEvalTest.java View 1 chunk +4 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +10 lines, -10 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java View 1 chunk +13 lines, -13 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/LinkerTests.java View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 11 chunks +36 lines, -37 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/AudioRecordInput.java View 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaDrmBridge.java View 4 chunks +8 lines, -8 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaPlayerListener.java View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/UsbMidiDeviceFactoryAndroid.java View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 3 chunks +11 lines, -11 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java View 1 chunk +4 lines, -4 lines 0 comments Download
M net/android/java/src/org/chromium/net/DefaultAndroidKeyStore.java View 3 chunks +6 lines, -6 lines 0 comments Download
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 chunk +2 lines, -2 lines 0 comments Download
M net/android/java/src/org/chromium/net/X509Util.java View 4 chunks +10 lines, -10 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 2 chunks +26 lines, -26 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Desktop.java View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/SessionConnector.java View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/ThirdPartyTokenFetcher.java View 3 chunks +9 lines, -10 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationIntentProtocol.java View 2 chunks +4 lines, -4 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java View 1 chunk +3 lines, -3 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 2 chunks +5 lines, -5 lines 0 comments Download
M testing/android/junit/javatests/src/org/chromium/testing/local/GtestLoggerTest.java View 6 chunks +18 lines, -18 lines 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 2 3 4 2 chunks +15 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 4 chunks +8 lines, -9 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/picker/DateTimeSuggestion.java View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/picker/InputDialogContainer.java View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
aurimas (slooooooooow)
tedchoc: PTAL
6 years, 1 month ago (2014-11-19 23:31:54 UTC) #2
Ted C
lgtm https://chromiumcodereview.appspot.com/744453002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java (right): https://chromiumcodereview.appspot.com/744453002/diff/1/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java#newcode212 android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java:212: + ".normal { " add leading spaces after ...
6 years, 1 month ago (2014-11-20 00:27:33 UTC) #3
Lambros
remoting/ lgtm
6 years, 1 month ago (2014-11-20 00:29:55 UTC) #5
gunsch
chromecast/ lgtm
6 years, 1 month ago (2014-11-20 00:31:23 UTC) #7
aurimas (slooooooooow)
https://codereview.chromium.org/744453002/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java File content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java (right): https://codereview.chromium.org/744453002/diff/1/content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java#newcode129 content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java:129: if (action == AccessibilityNodeInfo.ACTION_NEXT_AT_MOVEMENT_GRANULARITY || action On 2014/11/20 00:27:33, ...
6 years, 1 month ago (2014-11-20 01:21:59 UTC) #8
aurimas (slooooooooow)
samuong@chromium.org: Please review changes in chrome/test/chromedriver/ qinmin@chromium.org: Please review changes in media/ cbentzel@chromium.org: Please review ...
6 years, 1 month ago (2014-11-20 01:26:04 UTC) #10
qinmin
On 2014/11/20 01:26:04, aurimas wrote: > mailto:samuong@chromium.org: Please review changes in > chrome/test/chromedriver/ > > ...
6 years, 1 month ago (2014-11-20 01:31:44 UTC) #11
nyquist
//base and //sync lgtm
6 years, 1 month ago (2014-11-20 01:31:57 UTC) #12
boliu
android_webview lgtm
6 years, 1 month ago (2014-11-20 02:29:18 UTC) #13
cbentzel
net LGTM https://codereview.chromium.org/744453002/diff/20001/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java File net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java (right): https://codereview.chromium.org/744453002/diff/20001/net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java#newcode538 net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java:538: + "MDkAAAJNMIICSTCCAbKgAwIBAgIESEfU1jANBgkqhkiG9w0BAQUFADBpMQswCQYDVQQGEwJVUzET" This seems like a minor ...
6 years, 1 month ago (2014-11-20 11:33:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744453002/20001
6 years, 1 month ago (2014-11-20 17:18:04 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/94361) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/84224) win_gpu ...
6 years, 1 month ago (2014-11-20 17:24:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744453002/60001
6 years, 1 month ago (2014-11-20 17:31:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744453002/80001
6 years, 1 month ago (2014-11-20 17:39:45 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-20 18:46:17 UTC) #24
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:46:54 UTC) #25
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/cee75f0a7905c9e232900252142853a8b11d9701
Cr-Commit-Position: refs/heads/master@{#305047}

Powered by Google App Engine
This is Rietveld 408576698