content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java - Issue 744453002: Fix a bunch of Java Checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

Issue 744453002: Fix a bunch of Java Checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NeedsBraces to info Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ClipboardTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/ContentViewReadbackTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

index 176feee3137f582d7b2c606a5062f578f5e245d6..6d72ad120b2d40f940160a129ff1ddfd3b591f14 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java

@@ -59,12 +59,12 @@ public class ContentViewPopupZoomerTest extends ContentShellTestBase {

testUrl.append("<html><body>");

for (int i = 0; i < totalUrls; i++) {

boolean isTargeted = i == targetIdAt;

- testUrl.append("<a href=\"data:text/html;utf-8,<html><head><script>" +

- "function doesItWork() { return 'yes'; }</script></head></html>\"" +

- (isTargeted ? (" id=\"" + targetId + "\"") : "") + ">" +

- "<small><sup>" +

- (isTargeted ? "<b>" : "") + i + (isTargeted ? "</b>" : "") +

- "</sup></small></a>");

+ testUrl.append("<a href=\"data:text/html;utf-8,<html><head><script>"

+ + "function doesItWork() { return 'yes'; }</script></head></html>\""

+ + (isTargeted ? (" id=\"" + targetId + "\"") : "") + ">"

+ + "<small><sup>"

+ + (isTargeted ? "<b>" : "") + i + (isTargeted ? "</b>" : "")

+ + "</sup></small></a>");

}

testUrl.append("</small></div></body></html>");

return UrlUtils.encodeHtmlDataUri(testUrl.toString());