Need to reset enclosingPaginationLayer when a RenderLayer is removed from the tree.

Need to reset enclosingPaginationLayer when a RenderLayer is removed from the tree.

BUG=434728
R=chrishtr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185827

[mstensho (USE GERRIT), 2014-11-20 23:08:59]

I can add a test as well, but should I, bug being restricted and all?

[chrishtr, 2014-11-21 00:38:23]

On 2014/11/20 at 23:08:59, mstensho wrote:
> I can add a test as well, but should I, bug being restricted and all?

Yes. :)

I've sent you an email with some data to help.

[mstensho (USE GERRIT), 2014-11-21 08:34:27]

On 2014/11/21 00:38:23, chrishtr wrote:
> On 2014/11/20 at 23:08:59, mstensho wrote:
> > I can add a test as well, but should I, bug being restricted and all?
> 
> Yes. :)
> 
> I've sent you an email with some data to help.

Sorry, I meant: should I add a test to the CL, or is this too sensitive? I have
everything I need.

[pdr., 2014-11-21 08:43:24]

On 2014/11/21 at 08:34:27, mstensho wrote:
> On 2014/11/21 00:38:23, chrishtr wrote:
> > On 2014/11/20 at 23:08:59, mstensho wrote:
> > > I can add a test as well, but should I, bug being restricted and all?
> > 
> > Yes. :)
> > 
> > I've sent you an email with some data to help.
> 
> Sorry, I meant: should I add a test to the CL, or is this too sensitive? I
have everything I need.

Once a patch lands it's very easy for a security person to construct a testcase,
so we have included tests wherever possible in the past. For fuzzer-generated
tests we try to minimize them down to 5-10 lines before uploading though. I'm
not sure what Chris sent you and I don't have access to the bug, so take this
with a grain of salt :)

[mstensho (USE GERRIT), 2014-11-21 08:46:47]

On 2014/11/21 08:43:24, pdr wrote:
> On 2014/11/21 at 08:34:27, mstensho wrote:
> > On 2014/11/21 00:38:23, chrishtr wrote:
> > > On 2014/11/20 at 23:08:59, mstensho wrote:
> > > > I can add a test as well, but should I, bug being restricted and all?
> > > 
> > > Yes. :)
> > > 
> > > I've sent you an email with some data to help.
> > 
> > Sorry, I meant: should I add a test to the CL, or is this too sensitive? I
> have everything I need.
> 
> Once a patch lands it's very easy for a security person to construct a
testcase,
> so we have included tests wherever possible in the past. For fuzzer-generated
> tests we try to minimize them down to 5-10 lines before uploading though. I'm
> not sure what Chris sent you and I don't have access to the bug, so take this
> with a grain of salt :)

Just uploaded a test. Take a look if you want.

[chrishtr, 2014-11-21 18:38:32]

On 2014/11/21 at 08:34:27, mstensho wrote:
> On 2014/11/21 00:38:23, chrishtr wrote:
> > On 2014/11/20 at 23:08:59, mstensho wrote:
> > > I can add a test as well, but should I, bug being restricted and all?
> > 
> > Yes. :)
> > 
> > I've sent you an email with some data to help.
> 
> Sorry, I meant: should I add a test to the CL, or is this too sensitive? I
have everything I need.

Ah, ok. No it's not too sensitive. Every crash needs a testcase associated with
its fix, and the natural place to get the testcase is from the crash report.
Just be careful to make the testcase use generic CSS classes, etc.

[chrishtr, 2014-11-21 18:40:07]

https://codereview.chromium.org/744313002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/744313002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.cpp:538: void
RenderLayer::clearPaginationRecursive()
No caller for this method?

https://codereview.chromium.org/744313002/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/744313002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderLayer.cpp:538: void
RenderLayer::clearPaginationRecursive()
I can't see any callers of this new function. ?

[mstensho (USE GERRIT), 2014-11-21 20:38:22]

https://codereview.chromium.org/744313002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderLayer.cpp (right):

https://codereview.chromium.org/744313002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderLayer.cpp:538: void
RenderLayer::clearPaginationRecursive()
On 2014/11/21 18:40:06, chrishtr wrote:
> No caller for this method?

Oops.. that was what the code I added further down in this file was supposed to
do. But I managed to type updatePaginationRecursive() instead.

Done.

[chrishtr, 2014-11-21 20:56:58]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-11-21 20:56:58]

lgtm

[commit-bot: I haz the power, 2014-11-21 20:57:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744313002/40001

[commit-bot: I haz the power, 2014-11-21 22:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-21 22:06:54]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[mstensho (USE GERRIT), 2014-11-21 22:14:19]

The expectation file was put inside LayoutTests/virtual/ , which wasn't
intentional. Fixed that.

[mstensho (USE GERRIT), 2014-11-21 22:14:30]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-11-21 22:15:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744313002/60001

[commit-bot: I haz the power, 2014-11-21 23:42:25]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185827